From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: stable <stable@vger.kernel.org>,
David Miller <davem@davemloft.net>,
sashal@kernel.org
Subject: Re: net: validate untrusted gso packets without csum offload
Date: Thu, 21 Feb 2019 17:18:52 +0100 [thread overview]
Message-ID: <20190221161852.GE25800@kroah.com> (raw)
In-Reply-To: <CA+FuTSdeAaMB=xveBGQtQ-WSK=uHyYQBFWhbzUxh4b8FNNuWdA@mail.gmail.com>
On Thu, Feb 21, 2019 at 10:38:16AM -0500, Willem de Bruijn wrote:
> Unfortunately commit
>
> net: validate untrusted gso packets without csum offload
> d5be7f632bad0f489879eed0ff4b99bd7fe0b74c
>
> needs follow-up
>
> net: avoid false positives in untrusted gso validation
> http://patchwork.ozlabs.org/patch/1044429/
>
> It rejects illegal packets injected from userspace, including at
> least one that can crash the kernel. But I'm afraid it has false
> positives.
>
> I would suggest holding back on the backport to stable branches until
> both patches can go in together.
>
> If the second patch is not accepted, the alternative will be to revert
> this filter-based approach completely and fix the narrow kernel crash
> (but I'm afraid that syzkaller will just find others..)
>
> Apologies for the mess,
Ok, I will go drop this patch from all of the stable queues. Can you
remind me when your fixup hits Linus's tree so that I can queue up both
patches?
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-21 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:38 net: validate untrusted gso packets without csum offload Willem de Bruijn
2019-02-21 16:18 ` Greg Kroah-Hartman [this message]
2019-02-21 16:41 ` Willem de Bruijn
2019-02-24 22:53 ` Willem de Bruijn
2019-02-25 14:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221161852.GE25800@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox