* Re: syncconfig changes in 4.19.34 break builds
[not found] ` <CAK7LNAQtbuWOw5yGiCeodg0Kf+JGaJj6s6FSyDysxCLxtMBLeg@mail.gmail.com>
@ 2019-04-09 15:39 ` Sasha Levin
2019-04-11 4:27 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2019-04-09 15:39 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Ivan Babrou, Greg Kroah-Hartman, Linux Kbuild mailing list,
kernel-team, stable
On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote:
>Greg, Sasha,
>
>
>Sorry, the commit ID was wrong.
>
>
>The following commit for 4.19.x:
>
>commit 02826a6ba301b72461c3706e1cc66d5571cd327e
>Author: Masahiro Yamada <yamada.masahiro@socionext.com>
>Date: Mon Nov 5 16:52:34 2018 +0900
>
> kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was
that a mistake in the commit message?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: syncconfig changes in 4.19.34 break builds
2019-04-09 15:39 ` syncconfig changes in 4.19.34 break builds Sasha Levin
@ 2019-04-11 4:27 ` Masahiro Yamada
2019-04-11 13:47 ` Sasha Levin
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2019-04-11 4:27 UTC (permalink / raw)
To: Sasha Levin
Cc: Ivan Babrou, Greg Kroah-Hartman, Linux Kbuild mailing list,
kernel-team, stable
Hi Sasha,
On Wed, Apr 10, 2019 at 12:39 AM Sasha Levin <sashal@kernel.org> wrote:
>
> On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote:
> >Greg, Sasha,
> >
> >
> >Sorry, the commit ID was wrong.
> >
> >
> >The following commit for 4.19.x:
> >
> >commit 02826a6ba301b72461c3706e1cc66d5571cd327e
> >Author: Masahiro Yamada <yamada.masahiro@socionext.com>
> >Date: Mon Nov 5 16:52:34 2018 +0900
> >
> > kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
>
> This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was
> that a mistake in the commit message?
No. The commit message is correct.
The Fixes: tag points to the first bad commit in _upstream_.
What I want to say is:
638ecaf58369 [which was 9390dff66a5 in upstream]
depends on 02826a6ba301b, which is missing in v4.19.x branch.
638ecaf58369 was cherry-picked without correct patch
dependency, so it got broken. That's all.
There are two options to fix the breakage:
- backport 02826a6ba301b
OR
- revert 638ecaf58369.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: syncconfig changes in 4.19.34 break builds
2019-04-11 4:27 ` Masahiro Yamada
@ 2019-04-11 13:47 ` Sasha Levin
0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-04-11 13:47 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Ivan Babrou, Greg Kroah-Hartman, Linux Kbuild mailing list,
kernel-team, stable
On Thu, Apr 11, 2019 at 01:27:43PM +0900, Masahiro Yamada wrote:
>Hi Sasha,
>
>On Wed, Apr 10, 2019 at 12:39 AM Sasha Levin <sashal@kernel.org> wrote:
>>
>> On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote:
>> >Greg, Sasha,
>> >
>> >
>> >Sorry, the commit ID was wrong.
>> >
>> >
>> >The following commit for 4.19.x:
>> >
>> >commit 02826a6ba301b72461c3706e1cc66d5571cd327e
>> >Author: Masahiro Yamada <yamada.masahiro@socionext.com>
>> >Date: Mon Nov 5 16:52:34 2018 +0900
>> >
>> > kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
>>
>> This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was
>> that a mistake in the commit message?
>
>No. The commit message is correct.
>The Fixes: tag points to the first bad commit in _upstream_.
>
>
>What I want to say is:
>638ecaf58369 [which was 9390dff66a5 in upstream]
>depends on 02826a6ba301b, which is missing in v4.19.x branch.
>
>638ecaf58369 was cherry-picked without correct patch
>dependency, so it got broken. That's all.
>
>
>There are two options to fix the breakage:
> - backport 02826a6ba301b
> OR
> - revert 638ecaf58369.
Alrighty, I've picked 02826a6ba301b for 4.19, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-11 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CABWYdi1sSjZ8pw7tJpgvZyLfdJwT5judfjj7F3X5fLcAK3xvsw@mail.gmail.com>
[not found] ` <CAK7LNARvfpkO8D=xJ+GQMWuxX5a3RVkUsBg8XUgFz+4m=knK3Q@mail.gmail.com>
[not found] ` <CABWYdi1H9TnB32RCPL2axRvAf3sqf2K2BaoMs+0f-1CibfZ_Tg@mail.gmail.com>
[not found] ` <CAK7LNASjMrSrL+LhTuSq4T3juUbYSZUUtevUz=hwS+qFQiDuTg@mail.gmail.com>
[not found] ` <CAK7LNAQtbuWOw5yGiCeodg0Kf+JGaJj6s6FSyDysxCLxtMBLeg@mail.gmail.com>
2019-04-09 15:39 ` syncconfig changes in 4.19.34 break builds Sasha Levin
2019-04-11 4:27 ` Masahiro Yamada
2019-04-11 13:47 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox