From: Sasha Levin <sashal@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [Forw] [PATCH 1/2] modpost: file2alias: go back to simple devtable lookup
Date: Tue, 23 Apr 2019 10:56:01 -0400 [thread overview]
Message-ID: <20190423145601.GM17719@sasha-vm> (raw)
In-Reply-To: <20190423070832.GA20533@archlinux-i9>
On Tue, Apr 23, 2019 at 12:08:32AM -0700, Nathan Chancellor wrote:
>On Mon, Apr 22, 2019 at 02:22:39PM -0700, Matthias Kaehlcke wrote:
>> Hi,
>>
>> recent clang version rightfully barf when they come across ADD_TO_DEVTABLE:
>>
>> scripts/mod/file2alias.c:1222:1: warning: adding 'unsigned long' to
>> a string does not append to the string [-Wstring-plus-int]
>> ADD_TO_DEVTABLE("mei", mei_cl_device_id, do_mei_entry);
>>
>> scripts/mod/file2alias.c:108:13: note: expanded from macro
>> 'ADD_TO_DEVTABLE'
>> device_id + 0*sizeof((function)((const char *)NULL,
>>
>>
>> This can be addressed with the following upstream changes:
>>
>> f880eea68fe5 modpost: file2alias: check prototype of handler
>> ec91e78d378c modpost: file2alias: go back to simple devtable lookup
>>
>> Could these be added to -stable?
>>
>> This affects all versions back to 4.4 (no clang support for older
>> versions), though it's just a warning and the number of clang users
>> with older kernels is probably fairly limited.
>>
>
>[resending with Nick's correct email address]
>
>All of the clang commits have been backported to 4.4. It would be nice
>to have these commits because that warning is very noisy.
>
>Note, this will not apply cleanly to 4.4, 4.9, and 4.14. I have attached
>mbox files with the conflicts resolved, after build testing for arm64
>and x86_64. 4.19 is a clean cherry pick for me.
>
>Also added Masahiro to CC.
I've queued all of these for 4.4-4.19, and they already exist in 5.0.
Thanks all.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-04-23 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 21:22 [Forw] [PATCH 1/2] modpost: file2alias: go back to simple devtable lookup Matthias Kaehlcke
2019-04-23 7:05 ` Nathan Chancellor
2019-04-23 7:08 ` Nathan Chancellor
2019-04-23 14:56 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423145601.GM17719@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=mka@chromium.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=stable@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox