Re: [PATCH v2] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h>

Re: [PATCH v2] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h>

[Anisse Astier]

On Sat, Jun 15, 2019 at 10:16:00PM +0000, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 43d4da2c45b2 arm64/sve: ptrace and ELF coredump support.
> 
> The bot has tested the following trees: v5.1.9, v4.19.50.
> 
> v5.1.9: Build failed! Errors:
>     arch/arm64/kernel/ssbd.c:44:8: error: ‘PR_SPEC_ENABLE’ undeclared (first use in this function); did you mean ‘NR_PAGETABLE’?
>     arch/arm64/kernel/ssbd.c:46:8: error: ‘PR_SPEC_DISABLE’ undeclared (first use in this function); did you mean ‘PFA_SPEC_IB_DISABLE’?
>     arch/arm64/kernel/ssbd.c:47:8: error: ‘PR_SPEC_FORCE_DISABLE’ undeclared (first use in this function); did you mean ‘PFA_SPEC_IB_FORCE_DISABLE’?
>     arch/arm64/kernel/ssbd.c:93:7: error: ‘PR_SPEC_STORE_BYPASS’ undeclared (first use in this function)
>     arch/arm64/kernel/ssbd.c:106:10: error: ‘PR_SPEC_DISABLE’ undeclared (first use in this function); did you mean ‘PFA_SPEC_IB_DISABLE’?
>     arch/arm64/kernel/ssbd.c:109:11: error: ‘PR_SPEC_PRCTL’ undeclared (first use in this function); did you mean ‘PF_SECURITY’?
>     arch/arm64/kernel/ssbd.c:109:27: error: ‘PR_SPEC_FORCE_DISABLE’ undeclared (first use in this function); did you mean ‘PFA_SPEC_IB_FORCE_DISABLE’?
>     arch/arm64/kernel/ssbd.c:112:26: error: ‘PR_SPEC_ENABLE’ undeclared (first use in this function); did you mean ‘NR_PAGETABLE’?
>     arch/arm64/kernel/ssbd.c:116:10: error: ‘PR_SPEC_NOT_AFFECTED’ undeclared (first use in this function)
>     arch/arm64/kernel/ssbd.c:123:7: error: ‘PR_SPEC_STORE_BYPASS’ undeclared (first use in this function)
> 
> v4.19.50: Build OK!
> 
> How should we proceed with this patch?
> 

Looks like I was building without ARM64_SSBD. Although even enabling it
on Linus master does not trigger this build failure (I can reproduce on
5.1.y though).

I'll prepare a v3 anyway to make this linux/prctl.h dependency of ssbd.c
more explicit for 5.1.y backport.

Regards,

Anisse