Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: qutran@marvell.com, aeasi@marvell.com, emilne@redhat.com,
	hmadhani@marvell.com, martin.petersen@oracle.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] scsi: qla2xxx: Fix double scsi_done for abort path" failed to apply to 5.3-stable tree
Date: Sun, 15 Dec 2019 12:32:25 -0500	[thread overview]
Message-ID: <20191215173225.GE18043@sasha-vm> (raw)
In-Reply-To: <157633589722494@kroah.com>

On Sat, Dec 14, 2019 at 04:04:57PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.3-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From f45bca8c5052e8c59bab64ee90c44441678b9a52 Mon Sep 17 00:00:00 2001
>From: Quinn Tran <qutran@marvell.com>
>Date: Tue, 5 Nov 2019 07:06:54 -0800
>Subject: [PATCH] scsi: qla2xxx: Fix double scsi_done for abort path
>
>Current code assumes abort will remove the original command from the active
>list where scsi_done will not be called. Instead, the eh_abort thread will
>do the scsi_done. That is not the case.  Instead, we have a double
>scsi_done calls triggering use after free.
>
>Abort will tell FW to release the command from FW possesion. The original
>command will return to ULP with error in its normal fashion via scsi_done.
>eh_abort path would wait for the original command completion before
>returning.  eh_abort path will not perform the scsi_done call.
>
>Fixes: 219d27d7147e0 ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands")
>Cc: stable@vger.kernel.org # 5.2
>Link: https://lore.kernel.org/r/20191105150657.8092-6-hmadhani@marvell.com
>Reviewed-by: Ewan D. Milne <emilne@redhat.com>
>Signed-off-by: Quinn Tran <qutran@marvell.com>
>Signed-off-by: Arun Easi <aeasi@marvell.com>
>Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
>Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

I took these two additional patches to resolve the conflict:

	85cffefa09e4 ("scsi: qla2xxx: Fix a race condition between aborting and completing a SCSI command")
	bdb61b9b944d ("scsi: qla2xxx: Introduce the function qla2xxx_init_sp()")

-- 
Thanks,
Sasha

  reply	other threads:[~2019-12-15 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-14 15:04 FAILED: patch "[PATCH] scsi: qla2xxx: Fix double scsi_done for abort path" failed to apply to 5.3-stable tree gregkh
2019-12-15 17:32 ` Sasha Levin [this message]
2019-12-15 17:40   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191215173225.GE18043@sasha-vm \
    --to=sashal@kernel.org \
    --cc=aeasi@marvell.com \
    --cc=emilne@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hmadhani@marvell.com \
    --cc=martin.petersen@oracle.com \
    --cc=qutran@marvell.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox