From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: jmattson@google.com, ebiggers@kernel.org, jacobhxu@google.com,
pbonzini@redhat.com, pshier@google.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] kvm: x86: Host feature SSBD doesn't imply guest feature" failed to apply to 4.19-stable tree
Date: Wed, 1 Jan 2020 20:11:56 -0500 [thread overview]
Message-ID: <20200102011156.GE16372@sasha-vm> (raw)
In-Reply-To: <1577634666179186@kroah.com>
On Sun, Dec 29, 2019 at 04:51:06PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 396d2e878f92ec108e4293f1c77ea3bc90b414ff Mon Sep 17 00:00:00 2001
>From: Jim Mattson <jmattson@google.com>
>Date: Fri, 13 Dec 2019 16:15:15 -0800
>Subject: [PATCH] kvm: x86: Host feature SSBD doesn't imply guest feature
> SPEC_CTRL_SSBD
>
>The host reports support for the synthetic feature X86_FEATURE_SSBD
>when any of the three following hardware features are set:
> CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31]
> CPUID.80000008H:EBX.AMD_SSBD[bit 24]
> CPUID.80000008H:EBX.VIRT_SSBD[bit 25]
>
>Either of the first two hardware features implies the existence of the
>IA32_SPEC_CTRL MSR, but CPUID.80000008H:EBX.VIRT_SSBD[bit 25] does
>not. Therefore, CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31] should only be
>set in the guest if CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31] or
>CPUID.80000008H:EBX.AMD_SSBD[bit 24] is set on the host.
>
>Fixes: 0c54914d0c52a ("KVM: x86: use Intel speculation bugs and features as derived in generic x86 code")
>Signed-off-by: Jim Mattson <jmattson@google.com>
>Reviewed-by: Jacob Xu <jacobhxu@google.com>
>Reviewed-by: Peter Shier <pshier@google.com>
>Cc: Paolo Bonzini <pbonzini@redhat.com>
>Cc: stable@vger.kernel.org
>Reported-by: Eric Biggers <ebiggers@kernel.org>
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I don't think that this is needed on 4.19 and older, but it would be
nice if someone would ack.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-01-02 1:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 15:51 FAILED: patch "[PATCH] kvm: x86: Host feature SSBD doesn't imply guest feature" failed to apply to 4.19-stable tree gregkh
2020-01-02 1:11 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102011156.GE16372@sasha-vm \
--to=sashal@kernel.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacobhxu@google.com \
--cc=jmattson@google.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox