From: Sasha Levin <sashal@kernel.org>
To: Florian Bezdeka <florian@bezdeka.de>
Cc: stable@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 4.19] crypto: geode-aes - convert to skcipher API and make thread-safe
Date: Thu, 6 Feb 2020 14:15:17 -0500 [thread overview]
Message-ID: <20200206191517.GO31482@sasha-vm> (raw)
In-Reply-To: <20200206171534.4051-1-florian@bezdeka.de>
On Thu, Feb 06, 2020 at 06:15:34PM +0100, Florian Bezdeka wrote:
>commit 4549f7e5aa27ffc2cba63b5db8842a3b486f5688 upstream.
>
>The geode AES driver is heavily broken because it stores per-request
>state in the transform context. So it will crash or produce the wrong
>result if used by any of the many places in the kernel that issue
>concurrent requests for the same transform object.
>
>This driver is also implemented using the deprecated blkcipher API,
>which makes it difficult to fix, and puts it among the drivers
>preventing that API from being removed.
>
>Convert this driver to use the skcipher API, and change it to not store
>per-request state in the transform context.
>
>Fixes: 9fe757b ("[PATCH] crypto: Add support for the Geode LX AES hardware")
>Signed-off-by: Eric Biggers <ebiggers@google.com>
>Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>Signed-off-by: Florian Bezdeka <florian@bezdeka.de>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2020-02-06 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 17:15 [PATCH 4.19] crypto: geode-aes - convert to skcipher API and make thread-safe Florian Bezdeka
2020-02-06 19:05 ` Greg KH
2020-02-06 19:15 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206191517.GO31482@sasha-vm \
--to=sashal@kernel.org \
--cc=ebiggers@google.com \
--cc=florian@bezdeka.de \
--cc=herbert@gondor.apana.org.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox