From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: hverkuil-cisco@xs4all.nl, mchehab+huawei@kernel.org,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] media: cec: check 'transmit_in_progress', not 'transmitting'" failed to apply to 5.5-stable tree
Date: Sun, 9 Feb 2020 13:19:18 -0500 [thread overview]
Message-ID: <20200209181918.GO3584@sasha-vm> (raw)
In-Reply-To: <158124888510314@kroah.com>
On Sun, Feb 09, 2020 at 12:48:05PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.5-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From d51224b73d18d207912f15ad4eb7a4b456682729 Mon Sep 17 00:00:00 2001
>From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>Date: Wed, 11 Dec 2019 12:47:57 +0100
>Subject: [PATCH] media: cec: check 'transmit_in_progress', not 'transmitting'
>
>Currently wait_event_interruptible_timeout is called in cec_thread_func()
>when adap->transmitting is set. But if the adapter is unconfigured
>while transmitting, then adap->transmitting is set to NULL. But the
>hardware is still actually transmitting the message, and that's
>indicated by adap->transmit_in_progress and we should wait until that
>is finished or times out before transmitting new messages.
>
>As the original commit says: adap->transmitting is the userspace view,
>adap->transmit_in_progress reflects the hardware state.
>
>However, if adap->transmitting is NULL and adap->transmit_in_progress
>is true, then wait_event_interruptible is called (no timeout), which
>can get stuck indefinitely if the CEC driver is flaky and never marks
>the transmit-in-progress as 'done'.
>
>So test against transmit_in_progress when deciding whether to use
>the timeout variant or not, instead of testing against adap->transmitting.
>
>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>Fixes: 32804fcb612b ("media: cec: keep track of outstanding transmits")
>Cc: <stable@vger.kernel.org> # for v4.19 and up
>Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Duplicate commit:
ac479b51f3f4 ("media: cec: check 'transmit_in_progress', not 'transmitting'")
d51224b73d18 ("media: cec: check 'transmit_in_progress', not 'transmitting'")
--
Thanks,
Sasha
prev parent reply other threads:[~2020-02-09 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 11:48 FAILED: patch "[PATCH] media: cec: check 'transmit_in_progress', not 'transmitting'" failed to apply to 5.5-stable tree gregkh
2020-02-09 18:19 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200209181918.GO3584@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=mchehab+huawei@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox