Re: Patch "soc: fsl: qe: change return type of cpm_muram_alloc() to s32" has been added to the 5.5-stable tree

Re: Patch "soc: fsl: qe: change return type of cpm_muram_alloc() to s32" has been added to the 5.5-stable tree

[Rasmus Villemoes]

On 21/02/2020 02.27, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     soc: fsl: qe: change return type of cpm_muram_alloc() to s32
> 
> to the 5.5-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      soc-fsl-qe-change-return-type-of-cpm_muram_alloc-to-.patch
> and it can be found in the queue-5.5 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

Isn't that what I did when I replied to the AUTOSEL mail a week ago?

https://lore.kernel.org/stable/a920b57f-ad9e-5c25-3981-0462febd952a@rasmusvillemoes.dk/

The TL;DR is the last part of the middle paragraph "... I think they
should not be added to any -stable kernel."

Rasmus

Re: Patch "soc: fsl: qe: change return type of cpm_muram_alloc() to s32" has been added to the 5.5-stable tree

[Sasha Levin]

On Fri, Feb 21, 2020 at 09:53:04AM +0100, Rasmus Villemoes wrote:
>On 21/02/2020 02.27, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     soc: fsl: qe: change return type of cpm_muram_alloc() to s32
>>
>> to the 5.5-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      soc-fsl-qe-change-return-type-of-cpm_muram_alloc-to-.patch
>> and it can be found in the queue-5.5 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>
>Isn't that what I did when I replied to the AUTOSEL mail a week ago?
>
>https://lore.kernel.org/stable/a920b57f-ad9e-5c25-3981-0462febd952a@rasmusvillemoes.dk/
>
>The TL;DR is the last part of the middle paragraph "... I think they
>should not be added to any -stable kernel."

You did and I've missed your mail, sorry. I'll drop it now.

-- 
Thanks,
Sasha

Re: Patch "soc: fsl: qe: change return type of cpm_muram_alloc() to s32" has been added to the 5.5-stable tree

[Rasmus Villemoes]

On 21/02/2020 14.46, Sasha Levin wrote:
> On Fri, Feb 21, 2020 at 09:53:04AM +0100, Rasmus Villemoes wrote:
>> On 21/02/2020 02.27, Sasha Levin wrote:
>>> This is a note to let you know that I've just added the patch titled
>>>
>>>     soc: fsl: qe: change return type of cpm_muram_alloc() to s32
>>>
>>> to the 5.5-stable tree which can be found at:
>>>    
>>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>>
>>>
>>> The filename of the patch is:
>>>      soc-fsl-qe-change-return-type-of-cpm_muram_alloc-to-.patch
>>> and it can be found in the queue-5.5 subdirectory.
>>>
>>> If you, or anyone else, feels it should not be added to the stable tree,
>>> please let <stable@vger.kernel.org> know about it.
>>
>> Isn't that what I did when I replied to the AUTOSEL mail a week ago?
>>
>> https://lore.kernel.org/stable/a920b57f-ad9e-5c25-3981-0462febd952a@rasmusvillemoes.dk/
>>
>>
>> The TL;DR is the last part of the middle paragraph "... I think they
>> should not be added to any -stable kernel."
> 
> You did and I've missed your mail, sorry. I'll drop it now.

Uargh, I should have been more explicit and not provided a TL;DR.

Note the word 'they' (and I should also have caught the word "it"). My
original detailed mail concerned both "soc: fsl: qe: change return type
of cpm_muram_alloc() to s32" (which indeed got dropped) _and_
"net/wan/fsl_ucc_hdlc: reject muram offsets above 64K" which is now in
-stable :-(

I've re-read the code in fsl_ucc_hdlc.c, and I think we're lucky that it
will work even despite being taken without all its predecessors
(800cd6fb76f0 and on), so no need to revert it from -stable. But sigh.

Rasmus