* Re: [patch 01/10] x86/entry/32: Add missing ASM_CLAC to general_protection entry
[not found] ` <20200225220216.219537887@linutronix.de>
@ 2020-02-26 1:00 ` Frederic Weisbecker
2020-02-27 14:15 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner
1 sibling, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2020-02-26 1:00 UTC (permalink / raw)
To: Thomas Gleixner
Cc: LKML, x86, Steven Rostedt, Brian Gerst, Juergen Gross,
Paolo Bonzini, Arnd Bergmann, stable
On Tue, Feb 25, 2020 at 10:36:37PM +0100, Thomas Gleixner wrote:
> All exception entry points must have ASM_CLAC right at the
> beginning. The general_protection entry is missing one.
>
> Fixes: e59d1b0a2419 ("x86-32, smap: Add STAC/CLAC instructions to 32-bit kernel entry")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: x86/entry] x86/entry/32: Add missing ASM_CLAC to general_protection entry
[not found] ` <20200225220216.219537887@linutronix.de>
2020-02-26 1:00 ` [patch 01/10] x86/entry/32: Add missing ASM_CLAC to general_protection entry Frederic Weisbecker
@ 2020-02-27 14:15 ` tip-bot2 for Thomas Gleixner
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot2 for Thomas Gleixner @ 2020-02-27 14:15 UTC (permalink / raw)
To: linux-tip-commits
Cc: Thomas Gleixner, Frederic Weisbecker, Alexandre Chartre,
Andy Lutomirski, stable, x86, LKML
The following commit has been merged into the x86/entry branch of tip:
Commit-ID: 3d51507f29f2153a658df4a0674ec5b592b62085
Gitweb: https://git.kernel.org/tip/3d51507f29f2153a658df4a0674ec5b592b62085
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 25 Feb 2020 22:36:37 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 27 Feb 2020 14:48:38 +01:00
x86/entry/32: Add missing ASM_CLAC to general_protection entry
All exception entry points must have ASM_CLAC right at the
beginning. The general_protection entry is missing one.
Fixes: e59d1b0a2419 ("x86-32, smap: Add STAC/CLAC instructions to 32-bit kernel entry")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20200225220216.219537887@linutronix.de
---
arch/x86/entry/entry_32.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index 7e05604..39243df 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -1694,6 +1694,7 @@ SYM_CODE_START(int3)
SYM_CODE_END(int3)
SYM_CODE_START(general_protection)
+ ASM_CLAC
pushl $do_general_protection
jmp common_exception
SYM_CODE_END(general_protection)
^ permalink raw reply related [flat|nested] 2+ messages in thread