From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: glider@google.com, akpm@linux-foundation.org, dvyukov@google.com,
jpoimboe@redhat.com, kstewart@linuxfoundation.org,
matthias.bgg@gmail.com, stable@vger.kernel.org,
tglx@linutronix.de, torvalds@linux-foundation.org,
walter-zh.wu@mediatek.com
Subject: Re: FAILED: patch "[PATCH] lib/stackdepot.c: fix global out-of-bounds in stack_slabs" failed to apply to 4.19-stable tree
Date: Wed, 26 Feb 2020 21:47:35 -0500 [thread overview]
Message-ID: <20200227024735.GE22178@sasha-vm> (raw)
In-Reply-To: <1582714182242120@kroah.com>
On Wed, Feb 26, 2020 at 11:49:42AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 305e519ce48e935702c32241f07d393c3c8fed3e Mon Sep 17 00:00:00 2001
>From: Alexander Potapenko <glider@google.com>
>Date: Thu, 20 Feb 2020 20:04:30 -0800
>Subject: [PATCH] lib/stackdepot.c: fix global out-of-bounds in stack_slabs
>
>Walter Wu has reported a potential case in which init_stack_slab() is
>called after stack_slabs[STACK_ALLOC_MAX_SLABS - 1] has already been
>initialized. In that case init_stack_slab() will overwrite
>stack_slabs[STACK_ALLOC_MAX_SLABS], which may result in a memory
>corruption.
>
>Link: http://lkml.kernel.org/r/20200218102950.260263-1-glider@google.com
>Fixes: cd11016e5f521 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB")
>Signed-off-by: Alexander Potapenko <glider@google.com>
>Reported-by: Walter Wu <walter-zh.wu@mediatek.com>
>Cc: Dmitry Vyukov <dvyukov@google.com>
>Cc: Matthias Brugger <matthias.bgg@gmail.com>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Cc: Josh Poimboeuf <jpoimboe@redhat.com>
>Cc: Kate Stewart <kstewart@linuxfoundation.org>
>Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>Cc: <stable@vger.kernel.org>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
I've grabbed ee050dc83bc3 ("lib/stackdepot: Fix outdated comments") as a
dependency and queued for 4.19-4.9.
Technically the comment change is wrong as the commit it addresses is
older, but no one should be coding against the stable tree, and doing it
by changing 305e519ce48e would cause merge conflicts in the future.
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-02-27 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:49 FAILED: patch "[PATCH] lib/stackdepot.c: fix global out-of-bounds in stack_slabs" failed to apply to 4.19-stable tree gregkh
2020-02-27 2:47 ` Sasha Levin [this message]
2020-02-27 10:29 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227024735.GE22178@sasha-vm \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=kstewart@linuxfoundation.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=walter-zh.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox