From: Sasha Levin <sashal@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
gregkh@linuxfoundation.org, lirongqing@baidu.com,
stable@vger.kernel.org, vikram.pandita@ti.com
Subject: Re: FAILED: patch "[PATCH] serial: 8250: Check UPF_IRQ_SHARED in advance" failed to apply to 4.14-stable tree
Date: Fri, 28 Feb 2020 13:36:43 -0500 [thread overview]
Message-ID: <20200228183643.GB21491@sasha-vm> (raw)
In-Reply-To: <87r1yf2j57.fsf@kurt>
On Fri, Feb 28, 2020 at 09:47:16AM +0100, Kurt Kanzenbach wrote:
>Hi,
>
>On Thu Feb 27 2020, Andy Shevchenko wrote:
>> On Wed, Feb 26, 2020 at 06:39:49PM -0500, Sasha Levin wrote:
>>> On Wed, Feb 26, 2020 at 11:36:04AM +0100, gregkh@linuxfoundation.org wrote:
>>
>> ...
>>
>>> > Since this change we don't need to have custom solutions in 8250_aspeed_vuart
>>> > and 8250_of drivers, thus, drop them.
>>> >
>>> > Fixes: 1c2f04937b3e ("serial: 8250: add IRQ trigger support")
>>> > Reported-by: Li RongQing <lirongqing@baidu.com>
>>> > Cc: Kurt Kanzenbach <kurt@linutronix.de>
>>> > Cc: Vikram Pandita <vikram.pandita@ti.com>
>>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> > Cc: stable <stable@vger.kernel.org>
>>> > Acked-by: Kurt Kanzenbach <kurt@linutronix.de>
>>> > Link: https://lore.kernel.org/r/20200211135559.85960-1-andriy.shevchenko@linux.intel.com
>>> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>> For 4.14, I've worked around these missing commits:
>>>
>>> 5909c0bf9c7a ("serial/aspeed-vuart: Implement quick throttle mechanism")
>>> 989983ea849d ("serial/aspeed-vuart: Implement rx throttling")
>>> 54e53b2e8081 ("tty: serial: 8250: pass IRQ shared flag to UART ports")
>>
>> Thanks!
>>
>>> And queued up a backport. Older kernels are a bit trickier than that.
>
>Thanks for backporting. Why is it trickier?
>
>>
>> Since it's quite old bug and not many reports so far I guess we are not in
>> hurry to fix that old kernels.
>
>It would be quite nice to have that in v4.9 as well. My original patch
>was made against that tree and tested.
Hm, yes, looking at it now it doesn't look too tricky, I'm not sure what
happened a few days ago :)
If you want to send me a backport I'll be happy to queue it up.
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-02-28 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:36 FAILED: patch "[PATCH] serial: 8250: Check UPF_IRQ_SHARED in advance" failed to apply to 4.14-stable tree gregkh
2020-02-26 23:39 ` Sasha Levin
2020-02-27 9:59 ` Andy Shevchenko
2020-02-28 8:47 ` Kurt Kanzenbach
2020-02-28 18:36 ` Sasha Levin [this message]
2020-03-03 8:01 ` Kurt Kanzenbach
2020-03-03 8:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228183643.GB21491@sasha-vm \
--to=sashal@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurt@linutronix.de \
--cc=lirongqing@baidu.com \
--cc=stable@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox