block, bfq: port of a series of fix commits to 5.4 and 5.5

block, bfq: port of a series of fix commits to 5.4 and 5.5

[Paolo Valente]

Hi,
Fedora requested the following fix commits, currently available in
5.6-rc4, to be ported to 5.4 and 5.5 [1]:
db37a34c563b block, bfq: get a ref to a group when adding it to a service tree
4d8340d0d4d9 block, bfq: remove ifdefs from around gets/puts of bfq groups
33a16a980468 block, bfq: extend incomplete name of field on_st
ecedd3d7e199 block, bfq: get extra ref to prevent a queue from being freed during a group move
32c59e3a9a5a block, bfq: do not insert oom queue into position tree
f718b093277d block, bfq: do not plug I/O for bfq_queues with no proc refs

No change is needed for these commits to apply cleanly in 5.4 and 5.5.

Fedora asked for this porting because it will allow them to include
these commits in their kernels, and solve the crash that led me to the
making of the commits themselves [1].

This is the first time I submit something for stable branches, I hope
I did everything right (I'm following option 2 in [2]).

Thanks,
Paolo

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539
[2] https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst

Re: block, bfq: port of a series of fix commits to 5.4 and 5.5

[Thomas Backlund]

Den 05-03-2020 kl. 08:49, skrev Paolo Valente:
> Hi,
> Fedora requested the following fix commits, currently available in
> 5.6-rc4, to be ported to 5.4 and 5.5 [1]:
> db37a34c563b block, bfq: get a ref to a group when adding it to a service tree
> 4d8340d0d4d9 block, bfq: remove ifdefs from around gets/puts of bfq groups
> 33a16a980468 block, bfq: extend incomplete name of field on_st
> ecedd3d7e199 block, bfq: get extra ref to prevent a queue from being freed during a group move
> 32c59e3a9a5a block, bfq: do not insert oom queue into position tree
> f718b093277d block, bfq: do not plug I/O for bfq_queues with no proc refs
> 
> No change is needed for these commits to apply cleanly in 5.4 and 5.5.
> 

The last one is already in 5.5.6.

--
Thomas

Re: block, bfq: port of a series of fix commits to 5.4 and 5.5

[Paolo Valente]

> Il giorno 5 mar 2020, alle ore 13:35, Thomas Backlund <tmb@mageia.org> ha scritto:
> 
> Den 05-03-2020 kl. 08:49, skrev Paolo Valente:
>> Hi,
>> Fedora requested the following fix commits, currently available in
>> 5.6-rc4, to be ported to 5.4 and 5.5 [1]:
>> db37a34c563b block, bfq: get a ref to a group when adding it to a service tree
>> 4d8340d0d4d9 block, bfq: remove ifdefs from around gets/puts of bfq groups
>> 33a16a980468 block, bfq: extend incomplete name of field on_st
>> ecedd3d7e199 block, bfq: get extra ref to prevent a queue from being freed during a group move
>> 32c59e3a9a5a block, bfq: do not insert oom queue into position tree
>> f718b093277d block, bfq: do not plug I/O for bfq_queues with no proc refs
>> No change is needed for these commits to apply cleanly in 5.4 and 5.5.
> 
> The last one is already in 5.5.6.
> 

Ok, thanks.

Chris,
is 5.5.6 fine for RedHat?

THanks,
Paolo

> --
> Thomas

Re: block, bfq: port of a series of fix commits to 5.4 and 5.5

[Sasha Levin]

Hi Paolo,

On Thu, Mar 05, 2020 at 07:49:29AM +0100, Paolo Valente wrote:
>Hi,
>Fedora requested the following fix commits, currently available in
>5.6-rc4, to be ported to 5.4 and 5.5 [1]:
>db37a34c563b block, bfq: get a ref to a group when adding it to a service tree

I took this one.

>4d8340d0d4d9 block, bfq: remove ifdefs from around gets/puts of bfq groups

But not this one, it looks like a cleanup that isn't needed by the
following patches.

>33a16a980468 block, bfq: extend incomplete name of field on_st

Same as above.

>ecedd3d7e199 block, bfq: get extra ref to prevent a queue from being freed during a group move

I took this one.

>32c59e3a9a5a block, bfq: do not insert oom queue into position tree

And this one.

>f718b093277d block, bfq: do not plug I/O for bfq_queues with no proc refs

This patch seems to be already in.

>This is the first time I submit something for stable branches, I hope
>I did everything right (I'm following option 2 in [2]).

You did, thank you :)

-- 
Thanks,
Sasha