Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: longpeng2@huawei.com, arei.gonglei@huawei.com,
	clabbe@baylibre.com, davem@davemloft.net,
	herbert@gondor.apana.org.au, jasowang@redhat.com, mst@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] crypto: virtio: Fix src/dst scatterlist calculation in" failed to apply to 5.4-stable tree
Date: Mon, 15 Jun 2020 21:09:21 -0400	[thread overview]
Message-ID: <20200616010921.GM1931@sasha-vm> (raw)
In-Reply-To: <15922523850161@kroah.com>

On Mon, Jun 15, 2020 at 10:19:45PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From b02989f37fc5e865ceeee9070907e4493b3a21e2 Mon Sep 17 00:00:00 2001
>From: "Longpeng(Mike)" <longpeng2@huawei.com>
>Date: Tue, 2 Jun 2020 15:04:59 +0800
>Subject: [PATCH] crypto: virtio: Fix src/dst scatterlist calculation in
> __virtio_crypto_skcipher_do_req()
>
>The system will crash when the users insmod crypto/tcrypt.ko with mode=38
>( testing "cts(cbc(aes))" ).
>
>Usually the next entry of one sg will be @sg@ + 1, but if this sg element
>is part of a chained scatterlist, it could jump to the start of a new
>scatterlist array. Fix it by sg_next() on calculation of src/dst
>scatterlist.
>
>Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver")
>Reported-by: LABBE Corentin <clabbe@baylibre.com>
>Cc: Herbert Xu <herbert@gondor.apana.org.au>
>Cc: "Michael S. Tsirkin" <mst@redhat.com>
>Cc: Jason Wang <jasowang@redhat.com>
>Cc: "David S. Miller" <davem@davemloft.net>
>Cc: virtualization@lists.linux-foundation.org
>Cc: linux-kernel@vger.kernel.org
>Cc: stable@vger.kernel.org
>Link: https://lore.kernel.org/r/20200123101000.GB24255@Red
>Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
>Link: https://lore.kernel.org/r/20200602070501.2023-2-longpeng2@huawei.com
>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I've worked around missing eee1d6fca0a0 ("crypto: virtio - switch to
skcipher API") and queued it for 5.4, 4.19, and 4.14.

-- 
Thanks,
Sasha

      reply	other threads:[~2020-06-16  1:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 20:19 FAILED: patch "[PATCH] crypto: virtio: Fix src/dst scatterlist calculation in" failed to apply to 5.4-stable tree gregkh
2020-06-16  1:09 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200616010921.GM1931@sasha-vm \
    --to=sashal@kernel.org \
    --cc=arei.gonglei@huawei.com \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jasowang@redhat.com \
    --cc=longpeng2@huawei.com \
    --cc=mst@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox