* Re: [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
[not found] ` <20200525025049.3400-5-b-liu@ti.com>
@ 2020-06-17 8:17 ` Macpaul Lin
2020-06-17 8:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Macpaul Lin @ 2020-06-17 8:17 UTC (permalink / raw)
To: Bin Liu; +Cc: Greg Kroah-Hartman, linux-usb, stable
Bin Liu <b-liu@ti.com> 於 2020年5月25日 週一 上午10:53寫道：
>
> From: Macpaul Lin <macpaul.lin@mediatek.com>
>
> When receiving reset interrupt, FADDR need to be reset to zero in
> peripheral mode. Otherwise ep0 cannot do enumeration when re-plugging USB
> cable.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Acked-by: Min Guo <min.guo@mediatek.com>
> Signed-off-by: Bin Liu <b-liu@ti.com>
> ---
> drivers/usb/musb/mediatek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> index 6196b0e8d77d..eebeadd26946 100644
> --- a/drivers/usb/musb/mediatek.c
> +++ b/drivers/usb/musb/mediatek.c
> @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
>
> + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> + musb_ep_select(musb->mregs, 0);
> + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> + }
> +
> if (musb->int_usb || musb->int_tx || musb->int_rx)
> retval = musb_interrupt(musb);
>
> --
> 2.17.1
>
Could this bug fix also been applied to stable kernel?
Thanks!
Best regards,
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
2020-06-17 8:17 ` [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle Macpaul Lin
@ 2020-06-17 8:58 ` Greg Kroah-Hartman
2020-06-17 9:31 ` Macpaul Lin
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-17 8:58 UTC (permalink / raw)
To: Macpaul Lin; +Cc: Bin Liu, linux-usb, stable
On Wed, Jun 17, 2020 at 04:17:07PM +0800, Macpaul Lin wrote:
> Bin Liu <b-liu@ti.com> 於 2020年5月25日 週一 上午10:53寫道：
> >
> > From: Macpaul Lin <macpaul.lin@mediatek.com>
> >
> > When receiving reset interrupt, FADDR need to be reset to zero in
> > peripheral mode. Otherwise ep0 cannot do enumeration when re-plugging USB
> > cable.
> >
> > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > Acked-by: Min Guo <min.guo@mediatek.com>
> > Signed-off-by: Bin Liu <b-liu@ti.com>
> > ---
> > drivers/usb/musb/mediatek.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> > index 6196b0e8d77d..eebeadd26946 100644
> > --- a/drivers/usb/musb/mediatek.c
> > +++ b/drivers/usb/musb/mediatek.c
> > @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> > musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> > musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
> >
> > + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> > + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> > + musb_ep_select(musb->mregs, 0);
> > + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> > + }
> > +
> > if (musb->int_usb || musb->int_tx || musb->int_rx)
> > retval = musb_interrupt(musb);
> >
> > --
> > 2.17.1
> >
> Could this bug fix also been applied to stable kernel?
Sure, what is the git commit of it in Linus's tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
2020-06-17 8:58 ` Greg Kroah-Hartman
@ 2020-06-17 9:31 ` Macpaul Lin
2020-06-19 8:51 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Macpaul Lin @ 2020-06-17 9:31 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Macpaul Lin, Bin Liu, linux-usb, stable
On Wed, 2020-06-17 at 10:58 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 17, 2020 at 04:17:07PM +0800, Macpaul Lin wrote:
> > Bin Liu <b-liu@ti.com> 於 2020年5月25日 週一 上午10:53寫道：
> > >
> > > From: Macpaul Lin <macpaul.lin@mediatek.com>
> > >
> > > When receiving reset interrupt, FADDR need to be reset to zero in
> > > peripheral mode. Otherwise ep0 cannot do enumeration when re-plugging USB
> > > cable.
> > >
> > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > > Acked-by: Min Guo <min.guo@mediatek.com>
> > > Signed-off-by: Bin Liu <b-liu@ti.com>
> > > ---
> > > drivers/usb/musb/mediatek.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> > > index 6196b0e8d77d..eebeadd26946 100644
> > > --- a/drivers/usb/musb/mediatek.c
> > > +++ b/drivers/usb/musb/mediatek.c
> > > @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> > > musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> > > musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
> > >
> > > + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> > > + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> > > + musb_ep_select(musb->mregs, 0);
> > > + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> > > + }
> > > +
> > > if (musb->int_usb || musb->int_tx || musb->int_rx)
> > > retval = musb_interrupt(musb);
> > >
> > > --
> > > 2.17.1
> > >
> > Could this bug fix also been applied to stable kernel?
>
> Sure, what is the git commit of it in Linus's tree?
>
> thanks,
>
> greg k-h
The commit id of this patch should be
402bcac4b25b520c89ba60db85eb6316f36e797f
Thank you very much.
BR
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
2020-06-17 9:31 ` Macpaul Lin
@ 2020-06-19 8:51 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-19 8:51 UTC (permalink / raw)
To: Macpaul Lin; +Cc: Macpaul Lin, Bin Liu, linux-usb, stable
On Wed, Jun 17, 2020 at 05:31:57PM +0800, Macpaul Lin wrote:
> On Wed, 2020-06-17 at 10:58 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 17, 2020 at 04:17:07PM +0800, Macpaul Lin wrote:
> > > Bin Liu <b-liu@ti.com> 於 2020年5月25日 週一 上午10:53寫道：
> > > >
> > > > From: Macpaul Lin <macpaul.lin@mediatek.com>
> > > >
> > > > When receiving reset interrupt, FADDR need to be reset to zero in
> > > > peripheral mode. Otherwise ep0 cannot do enumeration when re-plugging USB
> > > > cable.
> > > >
> > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > > > Acked-by: Min Guo <min.guo@mediatek.com>
> > > > Signed-off-by: Bin Liu <b-liu@ti.com>
> > > > ---
> > > > drivers/usb/musb/mediatek.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> > > > index 6196b0e8d77d..eebeadd26946 100644
> > > > --- a/drivers/usb/musb/mediatek.c
> > > > +++ b/drivers/usb/musb/mediatek.c
> > > > @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> > > > musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> > > > musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
> > > >
> > > > + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> > > > + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> > > > + musb_ep_select(musb->mregs, 0);
> > > > + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> > > > + }
> > > > +
> > > > if (musb->int_usb || musb->int_tx || musb->int_rx)
> > > > retval = musb_interrupt(musb);
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > Could this bug fix also been applied to stable kernel?
> >
> > Sure, what is the git commit of it in Linus's tree?
> >
> > thanks,
> >
> > greg k-h
>
> The commit id of this patch should be
> 402bcac4b25b520c89ba60db85eb6316f36e797f
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 8:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200525025049.3400-1-b-liu@ti.com>
[not found] ` <20200525025049.3400-5-b-liu@ti.com>
2020-06-17 8:17 ` [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle Macpaul Lin
2020-06-17 8:58 ` Greg Kroah-Hartman
2020-06-17 9:31 ` Macpaul Lin
2020-06-19 8:51 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox