From: Sasha Levin <sashal@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
aarcange@redhat.com, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
songliubraving@fb.com, torvalds@linux-foundation.org,
stable-commits@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Patch "khugepaged: khugepaged_test_exit() check mmget_still_valid()" has been added to the 5.8-stable tree
Date: Mon, 24 Aug 2020 11:29:27 -0400 [thread overview]
Message-ID: <20200824152927.GH8670@sasha-vm> (raw)
In-Reply-To: <alpine.LSU.2.11.2008221900570.11463@eggly.anvils>
On Sat, Aug 22, 2020 at 07:16:39PM -0700, Hugh Dickins wrote:
>On Sat, 22 Aug 2020, Sasha Levin wrote:
>>
>> I've followed your instructions and backported the patches:
>>
>> bbe98f9cadff ("khugepaged: khugepaged_test_exit() check
>> mmget_still_valid()") - to all branches.
>> f3f99d63a815 ("khugepaged: adjust VM_BUG_ON_MM() in
>> __khugepaged_enter()") - to all branches.
>> 59ea6d06cfa9 ("coredump: fix race condition between collapse_huge_page()
>> and core dumping") - for 4.4.
>
>That's saved me time, thanks a lot for doing that work, Sasha.
>
>I've checked the results (haha, read on) and they're all fine,
>but one minor flaw in bisectability: the added 4.4 backport of
>"coredump: fix race condition..." adds a line (deleted by the next commit)
> result = SCAN_ANY_PROCESS;
>but neither "result" nor "SCAN_ANY_PROCESS" is defined in that tree,
>so that intermediate step would generate an easily fixed build error.
>
>FWIW - I don't know whether that's something to care about or not.
I'd probably prefer leaving it this way rather than dragging in more
patches or modifying the existing ones given that it doesn't effect
anything beyond bisectability.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-08-24 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1597841669128213@kroah.com>
2020-08-19 13:32 ` Patch "khugepaged: khugepaged_test_exit() check mmget_still_valid()" has been added to the 5.8-stable tree Hugh Dickins
2020-08-19 13:53 ` Greg KH
2020-08-22 1:26 ` Hugh Dickins
2020-08-22 21:20 ` Sasha Levin
2020-08-23 2:16 ` Hugh Dickins
2020-08-24 15:12 ` Hugh Dickins
2020-08-26 18:53 ` Hugh Dickins
2020-08-26 21:46 ` Sasha Levin
2020-08-26 21:54 ` Hugh Dickins
2020-08-24 15:29 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824152927.GH8670@sasha-vm \
--to=sashal@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=mike.kravetz@oracle.com \
--cc=songliubraving@fb.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox