From: Sasha Levin <sashal@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
aarcange@redhat.com, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
songliubraving@fb.com, torvalds@linux-foundation.org,
stable-commits@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Patch "khugepaged: khugepaged_test_exit() check mmget_still_valid()" has been added to the 5.8-stable tree
Date: Wed, 26 Aug 2020 17:46:23 -0400 [thread overview]
Message-ID: <20200826214623.GM8670@sasha-vm> (raw)
In-Reply-To: <alpine.LSU.2.11.2008261148000.1479@eggly.anvils>
On Wed, Aug 26, 2020 at 11:53:24AM -0700, Hugh Dickins wrote:
>On Mon, 24 Aug 2020, Hugh Dickins wrote:
>> On Sat, 22 Aug 2020, Hugh Dickins wrote:
>> > On Sat, 22 Aug 2020, Sasha Levin wrote:
>> > >
>> > > I've followed your instructions and backported the patches:
>> > >
>> > > bbe98f9cadff ("khugepaged: khugepaged_test_exit() check
>> > > mmget_still_valid()") - to all branches.
>> > > f3f99d63a815 ("khugepaged: adjust VM_BUG_ON_MM() in
>> > > __khugepaged_enter()") - to all branches.
>> > > 59ea6d06cfa9 ("coredump: fix race condition between collapse_huge_page()
>> > > and core dumping") - for 4.4.
>> >
>> > That's saved me time, thanks a lot for doing that work, Sasha.
>> >
>> > I've checked the results (haha, read on) and they're all fine,
>> > but one minor flaw in bisectability: the added 4.4 backport of
>> > "coredump: fix race condition..." adds a line (deleted by the next commit)
>> > result = SCAN_ANY_PROCESS;
>> > but neither "result" nor "SCAN_ANY_PROCESS" is defined in that tree,
>> > so that intermediate step would generate an easily fixed build error.
>> >
>> > FWIW - I don't know whether that's something to care about or not.
>>
>> Ah, but I missed that this one that we originally held back from 5.8,
>> did not in fact get re-added to 5.8: all the backport series have it,
>> but today's 5.8.4-rc1 does not have it.
>>
>> That's not a disaster - the series builds without it, and having its
>> fix without the fixed commit is just odd, no more unsafe than before;
>> but it should be re-added for a 5.8.4-rc2 or 5.8.5.
>
>I see 5.8 is at 5.8.5-rc1 today, but the commit below still missing:
>please re-add it, then we can all forget about it at last - thanks!
Greg went for a fast release cycle and I didn't have time to queue it
up, sorry. But don't worry - this patch isn't forgotten, I'll queue it
for the next release on Friday/Saturday.
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-08-26 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1597841669128213@kroah.com>
2020-08-19 13:32 ` Patch "khugepaged: khugepaged_test_exit() check mmget_still_valid()" has been added to the 5.8-stable tree Hugh Dickins
2020-08-19 13:53 ` Greg KH
2020-08-22 1:26 ` Hugh Dickins
2020-08-22 21:20 ` Sasha Levin
2020-08-23 2:16 ` Hugh Dickins
2020-08-24 15:12 ` Hugh Dickins
2020-08-26 18:53 ` Hugh Dickins
2020-08-26 21:46 ` Sasha Levin [this message]
2020-08-26 21:54 ` Hugh Dickins
2020-08-24 15:29 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826214623.GM8670@sasha-vm \
--to=sashal@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=mike.kravetz@oracle.com \
--cc=songliubraving@fb.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox