From: Sasha Levin <sashal@kernel.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: stable-commits@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: Patch "selftests: mptcp: depends on built-in IPv6" has been added to the 5.9-stable tree
Date: Mon, 26 Oct 2020 10:23:29 -0400 [thread overview]
Message-ID: <20201026142329.GJ4060117@sasha-vm> (raw)
In-Reply-To: <1de2bf78-4b47-21b0-9d56-3c8063cdf4bb@tessares.net>
On Mon, Oct 26, 2020 at 09:20:47AM +0100, Matthieu Baerts wrote:
>Hi Sasha,
>
>On 26/10/2020 06:18, Sasha Levin wrote:
>>This is a note to let you know that I've just added the patch titled
>>
>> selftests: mptcp: depends on built-in IPv6
>
>Thank you for backporting this patch.
>
>(...)
>
>> Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")
>
>This patch is not really needed because AFAICS this commit here above
>has not been backported to v5.9. It is only in v5.10-rc1.
>
>(...)
>
>>diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
>>index 8df5cb8f71ff9..741a1c4f4ae8f 100644
>>--- a/tools/testing/selftests/net/mptcp/config
>>+++ b/tools/testing/selftests/net/mptcp/config
>>@@ -1,4 +1,5 @@
>> CONFIG_MPTCP=y
>>+CONFIG_IPV6=y
>> CONFIG_MPTCP_IPV6=y
>
>But you can also keep this patch, it doesn't hurt: without this commit
>010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of
>selecting it"), CONFIG_MPTCP_IPV6=y selects CONFIG_IPV6=y. In other
>words, adding "CONFIG_IPV6=y" here in the selftests config is
>redundant if you don't have this commit 010b430d5df5 but not wrong.
>
>Note that if you also want to backport this commit 010b430d5df5
>("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it"),
>you will need commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as
>a module") as well.
I'll drop the selftests fix then, thanks for the heads-up!
--
Thanks,
Sasha
prev parent reply other threads:[~2020-10-26 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201026051850.8F51D206A1@mail.kernel.org>
2020-10-26 8:20 ` Patch "selftests: mptcp: depends on built-in IPv6" has been added to the 5.9-stable tree Matthieu Baerts
2020-10-26 14:23 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026142329.GJ4060117@sasha-vm \
--to=sashal@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox