* [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
@ 2020-10-28 9:49 Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sergei Antonov @ 2020-10-28 9:49 UTC (permalink / raw)
To: linux-mtd; +Cc: miquel.raynal, jianxin.pan, liang.yang, stable
Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Cc: stable@vger.kernel.org
Signed-off-by: Sergei Antonov <saproj@gmail.com>
---
drivers/mtd/nand/raw/meson_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index 48e6dac96be6..a76afea6ea77 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
}
static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
- int infolen, int datalen,
+ int datalen, int infolen,
enum dma_data_direction dir)
{
struct meson_nfc *nfc = nand_get_controller_data(nand);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
2020-10-28 9:49 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments Sergei Antonov
@ 2020-10-28 10:03 ` Miquel Raynal
2020-10-30 2:22 ` Liang Yang
2020-10-30 17:27 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2020-10-28 10:03 UTC (permalink / raw)
To: Sergei Antonov; +Cc: linux-mtd, jianxin.pan, liang.yang, stable
Hi Sergei,
Sergei Antonov <saproj@gmail.com> wrote on Wed, 28 Oct 2020 12:49:40
+0300:
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
>
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
This patch looks good to me. Next time you send a new iteration of a
patch, please use [PATCH v2] in the subject prefix and also add a
changelog below the three dashes.
(your other patch to fix the style is still welcome)
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 48e6dac96be6..a76afea6ea77 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
> }
>
> static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
> - int infolen, int datalen,
> + int datalen, int infolen,
> enum dma_data_direction dir)
> {
> struct meson_nfc *nfc = nand_get_controller_data(nand);
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
2020-10-28 9:49 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal
@ 2020-10-30 2:22 ` Liang Yang
2020-10-30 17:27 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Liang Yang @ 2020-10-30 2:22 UTC (permalink / raw)
To: Sergei Antonov, linux-mtd; +Cc: miquel.raynal, jianxin.pan, stable
Hi Sergei, miquel
On 2020/10/28 17:49, Sergei Antonov wrote:
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
>
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 48e6dac96be6..a76afea6ea77 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
> }
>
> static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
> - int infolen, int datalen,
> + int datalen, int infolen,
> enum dma_data_direction dir)
> {
> struct meson_nfc *nfc = nand_get_controller_data(nand);
It is good to me:
Acked-by: Liang Yang <liang.yang@amlogic.com>
and thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
2020-10-28 9:49 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal
2020-10-30 2:22 ` Liang Yang
@ 2020-10-30 17:27 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2020-10-30 17:27 UTC (permalink / raw)
To: Sergei Antonov, linux-mtd; +Cc: Miquel Raynal, liang.yang, stable, jianxin.pan
On Wed, 2020-10-28 at 09:49:40 UTC, Sergei Antonov wrote:
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
>
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-30 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 9:49 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal
2020-10-30 2:22 ` Liang Yang
2020-10-30 17:27 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox