Re: HID : Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

Re: HID : Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

[Dmitry Torokhov]

Hi Chris,

On Tue, Oct 27, 2020 at 12:57:51PM -0700, Chris Ye wrote:
> Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE
> 
> Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need
> to be set explicitly with this flag.
> Signed-off-by: Chris Ye <lzye@google.com>
> 

This is still line-wrapped and still is in HTML. It also is not
formatted so that maintainers scripts can process it properly. Please
follow Documentation/process/suubmitting-patches.rst "Canonical format
patch" section. I recommend using "git format-patch ..." to generate it
and git send-email for sending it.

Thanks.

> diff -uprN -X linux-vanilla/Documentation/dontdiff
> linux-vanilla/drivers/hid/hid-ids.h linux/drivers/hid/hid-ids.h
> --- linux-vanilla/drivers/hid/hid-ids.h 2020-10-26 22:16:49.930361683 -0700
> +++ linux/drivers/hid/hid-ids.h 2020-10-26 22:20:02.811994573 -0700
> @@ -443,6 +443,10 @@
> #define USB_VENDOR_ID_FRUCTEL  0x25B6
> #define USB_DEVICE_ID_GAMETEL_MT_MODE  0x0002
> 
> +#define USB_VENDOR_ID_GAMEVICE 0x27F8
> +#define USB_DEVICE_ID_GAMEVICE_GV186   0x0BBE
> +#define USB_DEVICE_ID_GAMEVICE_KISHI   0x0BBF
> +
> #define USB_VENDOR_ID_GAMERON          0x0810
> #define USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR 0x0001
> #define USB_DEVICE_ID_GAMERON_DUAL_PCS_ADAPTOR 0x0002
> diff -uprN -X linux-vanilla/Documentation/dontdiff
> linux-vanilla/drivers/hid/hid-quirks.c linux/drivers/hid/hid-quirks.c
> --- linux-vanilla/drivers/hid/hid-quirks.c      2020-10-26
> 22:16:49.930361683 -0700
> +++ linux/drivers/hid/hid-quirks.c      2020-10-26 22:20:02.811994573 -0700
> @@ -84,6 +84,8 @@ static const struct hid_device_id hid_qu
>        { HID_USB_DEVICE(USB_VENDOR_ID_FREESCALE,
> USB_DEVICE_ID_FREESCALE_MX28), HID_QUIRK_NOGET },
>        { HID_USB_DEVICE(USB_VENDOR_ID_FUTABA, USB_DEVICE_ID_LED_DISPLAY),
> HID_QUIRK_NO_INIT_REPORTS },
>        { HID_USB_DEVICE(USB_VENDOR_ID_GREENASIA,
> USB_DEVICE_ID_GREENASIA_DUAL_USB_JOYPAD), HID_QUIRK_MULTI_INPUT },
> +       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_GAMEVICE,
> USB_DEVICE_ID_GAMEVICE_GV186), HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
> +       { HID_USB_DEVICE(USB_VENDOR_ID_GAMEVICE,
> USB_DEVICE_ID_GAMEVICE_KISHI), HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
>        { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_DRIVING),
> HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
>        { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING),
> HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
>        { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING),
> HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },

-- 
Dmitry