From: Greg KH <gregkh@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "# 3.4.x" <stable@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Manoj Gupta <manojgupta@google.com>,
Luis Lozano <llozano@google.com>, Arnd Bergmann <arnd@arndb.de>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jian Cai <jiancai@google.com>
Subject: Re: [PATCH] crypto: x86/crc32c - fix building with clang ias
Date: Sat, 31 Oct 2020 11:30:20 +0100 [thread overview]
Message-ID: <20201031103020.GA961225@kroah.com> (raw)
In-Reply-To: <CAKwvOdmduyqjn7d6mG6CrSqCJC3ikJRphjWfKnqxvC2P=yoU2g@mail.gmail.com>
On Fri, Oct 30, 2020 at 12:06:28PM -0700, Nick Desaulniers wrote:
> + stable
>
> On Fri, Oct 30, 2020 at 12:04 PM Jian Cai <caij2003@gmail.com> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > commit 44623b2818f4 ("crypto: x86/crc32c - fix building with clang ias")
> > upstream
> >
> > The clang integrated assembler complains about movzxw:
> >
> > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instruction mnemonic 'movzxw'
> >
> > It seems that movzwq is the mnemonic that it expects instead,
> > and this is what objdump prints when disassembling the file.
> >
> > Fixes: 6a8ce1ef3940 ("crypto: crc32c - Optimize CRC32C calculation with PCLMULQDQ instruction")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> > [jc: Fixed conflicts due to lack of 34fdce6981b969]
Nit, please spell out commit ids as the documentation asks you to. I've
edited it and done that now...
thanks,
greg k-h
prev parent reply other threads:[~2020-10-31 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+SOCLLXnxcf=bTazCT1amY7B4_37HTEXL2OwHowVGCb8SLSQQ@mail.gmail.com>
2020-10-29 11:01 ` Backport 44623b2818f4a442726639572f44fd9b6d0ef68c to kernel 5.4 Greg KH
2020-10-29 18:05 ` Nick Desaulniers
2020-10-29 23:36 ` Sasha Levin
2020-10-29 23:45 ` Nick Desaulniers
2020-10-30 0:41 ` Sasha Levin
[not found] ` <CA+SOCLJqVjy9QRssE9AZ1nQBwZB5mAcanpVTVOd4kO3=r5jrfA@mail.gmail.com>
2020-10-30 1:49 ` Nathan Chancellor
[not found] ` <CA+SOCL+b_qvvEHFz5g416Kdfzy3nZQnizow9-C9k1pw=ZeoKJA@mail.gmail.com>
2020-10-30 19:30 ` Nick Desaulniers
[not found] ` <20201030190245.92967-1-jiancai@google.com>
2020-10-30 19:06 ` [PATCH] crypto: x86/crc32c - fix building with clang ias Nick Desaulniers
2020-10-31 10:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031103020.GA961225@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=herbert@gondor.apana.org.au \
--cc=jiancai@google.com \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox