Re: [PATCH 5.10 1/2] drm/i915/dg1: Wait for pcode/uncore handshake at startup

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Jun 02, 2023 at 06:05:06PM +0200, Henning Schild wrote:
> From: Matt Roper <matthew.d.roper@intel.com>
> 
> From: Matt Roper <matthew.d.roper@intel.com>

Twice?

> 
> [ Upstream commit f9c730ede7d3f40900cb493890d94d868ff2f00f ]
> 
> DG1 does some additional pcode/uncore handshaking at
> boot time; this handshaking must complete before various other pcode
> commands are effective and before general work is submitted to the GPU.
> We need to poll a new pcode mailbox during startup until it reports that
> this handshaking is complete.
> 
> The bspec doesn't give guidance on how long we may need to wait for this
> handshaking to complete.  For now, let's just set a really long timeout;
> if we still don't get a completion status by the end of that timeout,
> we'll just continue on and hope for the best.
> 
> v2 (Lucas): Rename macros to make clear the relation between command and
>    result (requested by José)
> 
> Bspec: 52065
> Cc: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201001063917.3133475-2-lucas.demarchi@intel.com

You also need to sign-off on a patch you submit for inclusion anywhere,
right?

Please resend this series with that added so that we can queue them up.

thanks,

greg k-h