* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause [not found] ` <d64874cb-8628-a6d2-d2f4-8af4d0ebf8b2@starfivetech.com> @ 2023-08-02 7:48 ` Conor Dooley 2023-08-02 8:17 ` Minda Chen 0 siblings, 1 reply; 6+ messages in thread From: Conor Dooley @ 2023-08-02 7:48 UTC (permalink / raw) To: Minda Chen Cc: Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable [-- Attachment #1: Type: text/plain, Size: 1755 bytes --] On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: > > > On 2023/8/2 14:54, Conor Dooley wrote: > > Hey Minda, > > > > On Wed, Aug 02, 2023 at 02:42:15PM +0800, Minda Chen wrote: > >> Actually it is a part of Conor's > >> commit aae538cd03bc ("riscv: fix detection of toolchain > >> Zihintpause support"). > >> It is looks like a merge issue. > > > > Yup, spot on. > > > >> Samuel's > >> commit 0b1d60d6dd9e ("riscv: Fix build with > >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y") do not base on Conor's commit and > >> revert to __riscv_zihintpause. So this patch can fix it. > >> > >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > > > > Did you actually manage to trigger this, or was this by inspection? > > clang-15 + binutils 2.35 was, IIRC, how we spotted this because that's > > what the clang-built-linux CI uses to test the LTS kernels from before > > LLVM's IAS was supported for RISC-V. Seemingly all that needs to be > > satisfied there is that zihintpause doesn't appear in -march so this has > > gone unnoticed. > > > > Fixes: 3c349eacc559 ("Merge patch "riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y"") > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > Thanks, > > Conor. > > > Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax > cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log > of processor.h found this issue. That doesn't look like it is fixed in later stable kernels (we are at 6.1.42-rcN right now I think). It sounds we should ask Greg to backport 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") to 6.1. Does that make sense to you? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause 2023-08-02 7:48 ` [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause Conor Dooley @ 2023-08-02 8:17 ` Minda Chen 2023-08-02 8:33 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Minda Chen @ 2023-08-02 8:17 UTC (permalink / raw) To: Conor Dooley Cc: Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable On 2023/8/2 15:48, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: >> >> >> On 2023/8/2 14:54, Conor Dooley wrote: >> > Hey Minda, >> > >> > On Wed, Aug 02, 2023 at 02:42:15PM +0800, Minda Chen wrote: >> >> Actually it is a part of Conor's >> >> commit aae538cd03bc ("riscv: fix detection of toolchain >> >> Zihintpause support"). >> >> It is looks like a merge issue. >> > >> > Yup, spot on. >> > >> >> Samuel's >> >> commit 0b1d60d6dd9e ("riscv: Fix build with >> >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y") do not base on Conor's commit and >> >> revert to __riscv_zihintpause. So this patch can fix it. >> >> >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> >> > >> > Did you actually manage to trigger this, or was this by inspection? >> > clang-15 + binutils 2.35 was, IIRC, how we spotted this because that's >> > what the clang-built-linux CI uses to test the LTS kernels from before >> > LLVM's IAS was supported for RISC-V. Seemingly all that needs to be >> > satisfied there is that zihintpause doesn't appear in -march so this has >> > gone unnoticed. >> > >> > Fixes: 3c349eacc559 ("Merge patch "riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y"") >> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> > >> > Thanks, >> > Conor. >> > >> Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax >> cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log >> of processor.h found this issue. > > That doesn't look like it is fixed in later stable kernels (we are at > 6.1.42-rcN right now I think). It sounds we should ask Greg to backport > 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") > to 6.1. Does that make sense to you? Yes. 6.1 is lts kernel. Starfive will use this kernel for a long time. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause 2023-08-02 8:17 ` Minda Chen @ 2023-08-02 8:33 ` Greg KH 2023-08-02 8:52 ` Conor Dooley 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2023-08-02 8:33 UTC (permalink / raw) To: Minda Chen Cc: Conor Dooley, Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable On Wed, Aug 02, 2023 at 04:17:51PM +0800, Minda Chen wrote: > > > On 2023/8/2 15:48, Conor Dooley wrote: > > On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: > >> > >> > >> On 2023/8/2 14:54, Conor Dooley wrote: > >> > Hey Minda, > >> > > >> > On Wed, Aug 02, 2023 at 02:42:15PM +0800, Minda Chen wrote: > >> >> Actually it is a part of Conor's > >> >> commit aae538cd03bc ("riscv: fix detection of toolchain > >> >> Zihintpause support"). > >> >> It is looks like a merge issue. > >> > > >> > Yup, spot on. > >> > > >> >> Samuel's > >> >> commit 0b1d60d6dd9e ("riscv: Fix build with > >> >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y") do not base on Conor's commit and > >> >> revert to __riscv_zihintpause. So this patch can fix it. > >> >> > >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > >> > > >> > Did you actually manage to trigger this, or was this by inspection? > >> > clang-15 + binutils 2.35 was, IIRC, how we spotted this because that's > >> > what the clang-built-linux CI uses to test the LTS kernels from before > >> > LLVM's IAS was supported for RISC-V. Seemingly all that needs to be > >> > satisfied there is that zihintpause doesn't appear in -march so this has > >> > gone unnoticed. > >> > > >> > Fixes: 3c349eacc559 ("Merge patch "riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y"") > >> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > >> > > >> > Thanks, > >> > Conor. > >> > > >> Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax > >> cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log > >> of processor.h found this issue. > > > > That doesn't look like it is fixed in later stable kernels (we are at > > 6.1.42-rcN right now I think). It sounds we should ask Greg to backport > > 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") > > to 6.1. Does that make sense to you? > Yes. 6.1 is lts kernel. Starfive will use this kernel for a long time. Thanks. What is preventing you from moving to a newer kernel version? All of your kernel changes are already properly merged into Linus's tree, right? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause 2023-08-02 8:33 ` Greg KH @ 2023-08-02 8:52 ` Conor Dooley 2023-08-02 9:42 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Conor Dooley @ 2023-08-02 8:52 UTC (permalink / raw) To: Greg KH Cc: Minda Chen, Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable [-- Attachment #1: Type: text/plain, Size: 2530 bytes --] On Wed, Aug 02, 2023 at 10:33:27AM +0200, Greg KH wrote: > On Wed, Aug 02, 2023 at 04:17:51PM +0800, Minda Chen wrote: > > > > > > On 2023/8/2 15:48, Conor Dooley wrote: > > > On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: > > >> > > >> > > >> On 2023/8/2 14:54, Conor Dooley wrote: > > >> > Hey Minda, > > >> > > > >> > On Wed, Aug 02, 2023 at 02:42:15PM +0800, Minda Chen wrote: > > >> >> Actually it is a part of Conor's > > >> >> commit aae538cd03bc ("riscv: fix detection of toolchain > > >> >> Zihintpause support"). > > >> >> It is looks like a merge issue. > > >> > > > >> > Yup, spot on. > > >> > > > >> >> Samuel's > > >> >> commit 0b1d60d6dd9e ("riscv: Fix build with > > >> >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y") do not base on Conor's commit and > > >> >> revert to __riscv_zihintpause. So this patch can fix it. > > >> >> > > >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > > >> > > > >> > Did you actually manage to trigger this, or was this by inspection? > > >> > clang-15 + binutils 2.35 was, IIRC, how we spotted this because that's > > >> > what the clang-built-linux CI uses to test the LTS kernels from before > > >> > LLVM's IAS was supported for RISC-V. Seemingly all that needs to be > > >> > satisfied there is that zihintpause doesn't appear in -march so this has > > >> > gone unnoticed. > > >> > > > >> > Fixes: 3c349eacc559 ("Merge patch "riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y"") > > >> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > >> > > > >> > Thanks, > > >> > Conor. > > >> > > > >> Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax > > >> cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log > > >> of processor.h found this issue. > > > > > > That doesn't look like it is fixed in later stable kernels (we are at > > > 6.1.42-rcN right now I think). It sounds we should ask Greg to backport > > > 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") > > > to 6.1. Does that make sense to you? > > Yes. 6.1 is lts kernel. Starfive will use this kernel for a long time. Thanks. > > What is preventing you from moving to a newer kernel version? All of > your kernel changes are already properly merged into Linus's tree, > right? Regardless of their reasons, "vdso.so call cpu_relax cause application core dump" is something that we should fix in stable kernels, no? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause 2023-08-02 8:52 ` Conor Dooley @ 2023-08-02 9:42 ` Greg KH 2023-08-02 9:50 ` Conor Dooley 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2023-08-02 9:42 UTC (permalink / raw) To: Conor Dooley Cc: Minda Chen, Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable On Wed, Aug 02, 2023 at 09:52:45AM +0100, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 10:33:27AM +0200, Greg KH wrote: > > On Wed, Aug 02, 2023 at 04:17:51PM +0800, Minda Chen wrote: > > > > > > > > > On 2023/8/2 15:48, Conor Dooley wrote: > > > > On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: > > > >> > > > >> > > > >> On 2023/8/2 14:54, Conor Dooley wrote: > > > >> > Hey Minda, > > > >> > > > > >> > On Wed, Aug 02, 2023 at 02:42:15PM +0800, Minda Chen wrote: > > > >> >> Actually it is a part of Conor's > > > >> >> commit aae538cd03bc ("riscv: fix detection of toolchain > > > >> >> Zihintpause support"). > > > >> >> It is looks like a merge issue. > > > >> > > > > >> > Yup, spot on. > > > >> > > > > >> >> Samuel's > > > >> >> commit 0b1d60d6dd9e ("riscv: Fix build with > > > >> >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y") do not base on Conor's commit and > > > >> >> revert to __riscv_zihintpause. So this patch can fix it. > > > >> >> > > > >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > > > >> > > > > >> > Did you actually manage to trigger this, or was this by inspection? > > > >> > clang-15 + binutils 2.35 was, IIRC, how we spotted this because that's > > > >> > what the clang-built-linux CI uses to test the LTS kernels from before > > > >> > LLVM's IAS was supported for RISC-V. Seemingly all that needs to be > > > >> > satisfied there is that zihintpause doesn't appear in -march so this has > > > >> > gone unnoticed. > > > >> > > > > >> > Fixes: 3c349eacc559 ("Merge patch "riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y"") > > > >> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > >> > > > > >> > Thanks, > > > >> > Conor. > > > >> > > > > >> Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax > > > >> cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log > > > >> of processor.h found this issue. > > > > > > > > That doesn't look like it is fixed in later stable kernels (we are at > > > > 6.1.42-rcN right now I think). It sounds we should ask Greg to backport > > > > 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") > > > > to 6.1. Does that make sense to you? > > > Yes. 6.1 is lts kernel. Starfive will use this kernel for a long time. Thanks. > > > > What is preventing you from moving to a newer kernel version? All of > > your kernel changes are already properly merged into Linus's tree, > > right? > > Regardless of their reasons, "vdso.so call cpu_relax cause application > core dump" is something that we should fix in stable kernels, no? Yes. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause 2023-08-02 9:42 ` Greg KH @ 2023-08-02 9:50 ` Conor Dooley 0 siblings, 0 replies; 6+ messages in thread From: Conor Dooley @ 2023-08-02 9:50 UTC (permalink / raw) To: Greg KH Cc: Minda Chen, Conor Dooley, Jisheng Zhang, Samuel Holland, Dao Lu, Heiko Stuebner, Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel, linux-riscv, Mason Huo, stable [-- Attachment #1: Type: text/plain, Size: 1614 bytes --] On Wed, Aug 02, 2023 at 11:42:59AM +0200, Greg KH wrote: > On Wed, Aug 02, 2023 at 09:52:45AM +0100, Conor Dooley wrote: > > On Wed, Aug 02, 2023 at 10:33:27AM +0200, Greg KH wrote: > > > On Wed, Aug 02, 2023 at 04:17:51PM +0800, Minda Chen wrote: > > > > On 2023/8/2 15:48, Conor Dooley wrote: > > > > > On Wed, Aug 02, 2023 at 03:32:15PM +0800, Minda Chen wrote: > > > > >> On 2023/8/2 14:54, Conor Dooley wrote: > > > > >> Thanks, Conor. I found this just by inspection. I found a issue that vdso.so call cpu_relax > > > > >> cause application core dump in kernel 6.1.31. I need Samuel'patch to fix this. And I search the log > > > > >> of processor.h found this issue. > > > > > > > > > > That doesn't look like it is fixed in later stable kernels (we are at > > > > > 6.1.42-rcN right now I think). It sounds we should ask Greg to backport > > > > > 0b1d60d6dd9e ("riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y") > > > > > to 6.1. Does that make sense to you? > > > > Yes. 6.1 is lts kernel. Starfive will use this kernel for a long time. Thanks. > > > > > > What is preventing you from moving to a newer kernel version? All of > > > your kernel changes are already properly merged into Linus's tree, > > > right? > > > > Regardless of their reasons, "vdso.so call cpu_relax cause application > > core dump" is something that we should fix in stable kernels, no? > > Yes. It doesn't apply cleanly as a cherry-pick onto linux-6.1, so it'll need to be submitted. Maybe Minda can do that, since they've got an already tested version of the patch. Failing that, I will. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-02 9:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230802064215.31111-1-minda.chen@starfivetech.com>
[not found] ` <20230802-sharpness-spoon-f9b8804fb66f@wendy>
[not found] ` <d64874cb-8628-a6d2-d2f4-8af4d0ebf8b2@starfivetech.com>
2023-08-02 7:48 ` [PATCH v1] riscv: Using TOOLCHAIN_HAS_ZIHINTPAUSE marco replace zihintpause Conor Dooley
2023-08-02 8:17 ` Minda Chen
2023-08-02 8:33 ` Greg KH
2023-08-02 8:52 ` Conor Dooley
2023-08-02 9:42 ` Greg KH
2023-08-02 9:50 ` Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox