Re: [PATCH v6.1] hwmon: (aquacomputer_d5next) Add selective 200ms delay after sending ctrl report

[Greg KH <greg@kroah.com>]

On Thu, Aug 24, 2023 at 04:26:10PM +0200, Aleksa Savic wrote:
> On 2023-08-24 16:15:00 GMT+02:00, Aleksa Savic wrote:
> > commit 56b930dcd88c2adc261410501c402c790980bdb5 upstream.
> > 
> > Add a 200ms delay after sending a ctrl report to Quadro,
> > Octo, D5 Next and Aquaero to give them enough time to
> > process the request and save the data to memory. Otherwise,
> > under heavier userspace loads where multiple sysfs entries
> > are usually set in quick succession, a new ctrl report could
> > be requested from the device while it's still processing the
> > previous one and fail with -EPIPE. The delay is only applied
> > if two ctrl report operations are near each other in time.
> > 
> > Reported by a user on Github [1] and tested by both of us.
> > 
> > [1] https://github.com/aleksamagicka/aquacomputer_d5next-hwmon/issues/82
> > 
> > Fixes: 752b927951ea ("hwmon: (aquacomputer_d5next) Add support for Aquacomputer Octo")
> > Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
> > ---
> > This is a backport of the upstream commit to v6.1. No functional
> > changes, except that Aquaero support first appeared in
> > v6.3, so that part of the original is not included here.
> > ---
> 
> Just noticed that I left in the Aquaero mention in the commit
> message, sorry for the omission... Do I need to resend?

Nah, that's fine, we want to keep the changelog identical, I left your
note in the signed-off-by area explaining it.

thanks,

greg k-h