From: Aleksa Savic <savicaleksa83@gmail.com>
To: stable@vger.kernel.org
Cc: savicaleksa83@gmail.com
Subject: Re: [PATCH v6.1] hwmon: (aquacomputer_d5next) Add selective 200ms delay after sending ctrl report
Date: Thu, 24 Aug 2023 16:26:10 +0200 [thread overview]
Message-ID: <c4197112-986d-81f2-53aa-7d53086d5eb2@gmail.com> (raw)
In-Reply-To: <20230824141500.1813549-1-savicaleksa83@gmail.com>
On 2023-08-24 16:15:00 GMT+02:00, Aleksa Savic wrote:
> commit 56b930dcd88c2adc261410501c402c790980bdb5 upstream.
>
> Add a 200ms delay after sending a ctrl report to Quadro,
> Octo, D5 Next and Aquaero to give them enough time to
> process the request and save the data to memory. Otherwise,
> under heavier userspace loads where multiple sysfs entries
> are usually set in quick succession, a new ctrl report could
> be requested from the device while it's still processing the
> previous one and fail with -EPIPE. The delay is only applied
> if two ctrl report operations are near each other in time.
>
> Reported by a user on Github [1] and tested by both of us.
>
> [1] https://github.com/aleksamagicka/aquacomputer_d5next-hwmon/issues/82
>
> Fixes: 752b927951ea ("hwmon: (aquacomputer_d5next) Add support for Aquacomputer Octo")
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
> ---
> This is a backport of the upstream commit to v6.1. No functional
> changes, except that Aquaero support first appeared in
> v6.3, so that part of the original is not included here.
> ---
Just noticed that I left in the Aquaero mention in the commit
message, sorry for the omission... Do I need to resend?
Aleksa
next prev parent reply other threads:[~2023-08-24 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 17:53 FAILED: patch "[PATCH] hwmon: (aquacomputer_d5next) Add selective 200ms delay after" failed to apply to 6.1-stable tree gregkh
2023-08-24 14:15 ` [PATCH v6.1] hwmon: (aquacomputer_d5next) Add selective 200ms delay after sending ctrl report Aleksa Savic
2023-08-24 14:26 ` Aleksa Savic [this message]
2023-08-27 7:01 ` Greg KH
2023-08-27 14:16 ` Aleksa Savic
2023-08-27 7:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4197112-986d-81f2-53aa-7d53086d5eb2@gmail.com \
--to=savicaleksa83@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox