From: Greg KH <greg@kroah.com>
To: Shaoying Xu <shaoyi@amazon.com>
Cc: stable@vger.kernel.org, markovicbudimir@gmail.com,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 4.14] net/sched: sch_hfsc: Ensure inner classes have fsc curve
Date: Sat, 7 Oct 2023 13:24:32 +0200 [thread overview]
Message-ID: <2023100716-hacksaw-pampers-22f1@gregkh> (raw)
In-Reply-To: <20230920175145.23384-1-shaoyi@amazon.com>
On Wed, Sep 20, 2023 at 05:51:45PM +0000, Shaoying Xu wrote:
> From: Budimir Markovic <markovicbudimir@gmail.com>
>
> [ Upstream commit b3d26c5702c7d6c45456326e56d2ccf3f103e60f ]
>
> HFSC assumes that inner classes have an fsc curve, but it is currently
> possible for classes without an fsc curve to become parents. This leads
> to bugs including a use-after-free.
>
> Don't allow non-root classes without HFSC_FSC to become parents.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Budimir Markovic <markovicbudimir@gmail.com>
> Signed-off-by: Budimir Markovic <markovicbudimir@gmail.com>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Link: https://lore.kernel.org/r/20230824084905.422-1-markovicbudimir@gmail.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> [ v4.14: Delete NL_SET_ERR_MSG because extack is not added to hfsc_change_class ]
> Cc: <stable@vger.kernel.org> # 4.14
Trailing whitespace, please fix your editor :(
Anyway, now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-10-07 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 17:51 [PATCH 4.14] net/sched: sch_hfsc: Ensure inner classes have fsc curve Shaoying Xu
2023-09-27 3:21 ` Shaoying Xu
2023-09-27 6:03 ` Greg KH
2023-10-07 11:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100716-hacksaw-pampers-22f1@gregkh \
--to=greg@kroah.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=markovicbudimir@gmail.com \
--cc=shaoyi@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox