Re: Patch "tty: 8250: Add support for Intashield IX cards" has been added to the 5.10-stable tree

Re: Patch "tty: 8250: Add support for Intashield IX cards" has been added to the 5.10-stable tree

[Cameron Williams]

On Mon, Nov 06, 2023 at 01:18:36PM +0100, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     tty: 8250: Add support for Intashield IX cards
> 
> to the 5.10-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      tty-8250-add-support-for-intashield-ix-cards.patch
> and it can be found in the queue-5.10 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
I don't think this patch should be in 5.10-stable. It's using the
pbn_oxsemi_x_15625000 configuration which isn't available in the version
of the driver (it's actually pbn_oxsemi_x_3906250 in this version).
The rest of the patches to be merged look OK for this branch (as they are
all using the generic configuration rather than Oxsemi).
> 
Thanks,
Cameron
> From 62d2ec2ded278c7512d91ca7bf8eb9bac46baf90 Mon Sep 17 00:00:00 2001
> From: Cameron Williams <cang1@live.co.uk>
> Date: Fri, 20 Oct 2023 17:03:16 +0100
> Subject: tty: 8250: Add support for Intashield IX cards
> 
> From: Cameron Williams <cang1@live.co.uk>
> 
> commit 62d2ec2ded278c7512d91ca7bf8eb9bac46baf90 upstream.
> 
> Add support for the IX-100, IX-200 and IX-400 serial cards.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Cameron Williams <cang1@live.co.uk>
> Link: https://lore.kernel.org/r/DU0PR02MB7899614E5837E82A03272A4BC4DBA@DU0PR02MB7899.eurprd02.prod.outlook.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/tty/serial/8250/8250_pci.c |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -5150,6 +5150,27 @@ static const struct pci_device_id serial
>  	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS400,
>  		PCI_ANY_ID, PCI_ANY_ID, 0, 0,    /* 135a.0dc0 */
>  		pbn_b2_4_115200 },
> +	/*
> +	 * IntaShield IX-100
> +	 */
> +	{	PCI_VENDOR_ID_INTASHIELD, 0x4027,
> +		PCI_ANY_ID, PCI_ANY_ID,
> +		0, 0,
> +		pbn_oxsemi_1_15625000 },
> +	/*
> +	 * IntaShield IX-200
> +	 */
> +	{	PCI_VENDOR_ID_INTASHIELD, 0x4028,
> +		PCI_ANY_ID, PCI_ANY_ID,
> +		0, 0,
> +		pbn_oxsemi_2_15625000 },
> +	/*
> +	 * IntaShield IX-400
> +	 */
> +	{	PCI_VENDOR_ID_INTASHIELD, 0x4029,
> +		PCI_ANY_ID, PCI_ANY_ID,
> +		0, 0,
> +		pbn_oxsemi_4_15625000 },
>  	/* Brainboxes Devices */
>  	/*
>  	* Brainboxes UC-101
> 
> 
> Patches currently in stable-queue which might be from cang1@live.co.uk are
> 
> queue-5.10/tty-8250-add-support-for-additional-brainboxes-uc-cards.patch
> queue-5.10/tty-8250-add-support-for-intashield-ix-cards.patch
> queue-5.10/tty-8250-add-support-for-brainboxes-up-cards.patch
> queue-5.10/tty-8250-add-support-for-intashield-is-100.patch
> queue-5.10/tty-8250-remove-uc-257-and-uc-431.patch

Re: Patch "tty: 8250: Add support for Intashield IX cards" has been added to the 5.10-stable tree

[Greg KH]

On Mon, Nov 06, 2023 at 12:56:23PM +0000, Cameron Williams wrote:
> On Mon, Nov 06, 2023 at 01:18:36PM +0100, gregkh@linuxfoundation.org wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     tty: 8250: Add support for Intashield IX cards
> > 
> > to the 5.10-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      tty-8250-add-support-for-intashield-ix-cards.patch
> > and it can be found in the queue-5.10 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> I don't think this patch should be in 5.10-stable. It's using the
> pbn_oxsemi_x_15625000 configuration which isn't available in the version
> of the driver (it's actually pbn_oxsemi_x_3906250 in this version).
> The rest of the patches to be merged look OK for this branch (as they are
> all using the generic configuration rather than Oxsemi).

Yes, it broke the build and I dropped it right after it, my scripts
committed it before I could build-test it.

thanks for the quick response!

greg k-h