* Re: [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get
2023-11-10 1:29 ` [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get Stuart Lee
@ 2023-11-10 2:00 ` CK Hu (胡俊光)
2023-11-10 11:57 ` AngeloGioacchino Del Regno
2023-12-11 14:44 ` Chun-Kuang Hu
2 siblings, 0 replies; 5+ messages in thread
From: CK Hu (胡俊光) @ 2023-11-10 2:00 UTC (permalink / raw)
To: Stuart Lee (李翰), chunkuang.hu@kernel.org,
angelogioacchino.delregno@collabora.com
Cc: Pablo Sun (孫毓翔),
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Shawn Sung (宋孝謙),
Nancy Lin (林欣螢), stable@vger.kernel.org,
daniel@ffwll.ch, p.zabel@pengutronix.de,
dri-devel@lists.freedesktop.org,
Macpaul Lin (林智斌), airlied@gmail.com,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
Lancelot Wu (吳瑋晟)
Hi, Stuart:
On Fri, 2023-11-10 at 09:29 +0800, Stuart Lee wrote:
> Add error handling to check NULL input in
> mtk_drm_crtc_dma_dev_get function.
>
> While display path is not configured correctly, none of crtc is
> established. So the caller of mtk_drm_crtc_dma_dev_get may pass
> input parameter *crtc as NULL, Which may cause coredump when
> we try to get the container of NULL pointer.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: cb1d6bcca542 ("drm/mediatek: Add dma dev get function")
> Signed-off-by: Stuart Lee <stuart.lee@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index c277b9fae950..047c9a31d306 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -921,7 +921,14 @@ static int mtk_drm_crtc_init_comp_planes(struct
> drm_device *drm_dev,
>
> struct device *mtk_drm_crtc_dma_dev_get(struct drm_crtc *crtc)
> {
> - struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
> + struct mtk_drm_crtc *mtk_crtc = NULL;
> +
> + if (!crtc)
> + return NULL;
> +
> + mtk_crtc = to_mtk_crtc(crtc);
> + if (!mtk_crtc)
> + return NULL;
>
> return mtk_crtc->dma_dev;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get
2023-11-10 1:29 ` [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get Stuart Lee
2023-11-10 2:00 ` CK Hu (胡俊光)
@ 2023-11-10 11:57 ` AngeloGioacchino Del Regno
2023-12-11 14:44 ` Chun-Kuang Hu
2 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-10 11:57 UTC (permalink / raw)
To: Stuart Lee, Chun-Kuang Hu
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
Nancy . Lin, dri-devel, linux-mediatek, linux-kernel,
linux-arm-kernel, Lancelot Wu, Shawn Sung, Pablo Sun, Macpaul Lin,
stable
Il 10/11/23 02:29, Stuart Lee ha scritto:
> Add error handling to check NULL input in
> mtk_drm_crtc_dma_dev_get function.
>
> While display path is not configured correctly, none of crtc is
> established. So the caller of mtk_drm_crtc_dma_dev_get may pass
> input parameter *crtc as NULL, Which may cause coredump when
> we try to get the container of NULL pointer.
>
> Fixes: cb1d6bcca542 ("drm/mediatek: Add dma dev get function")
> Signed-off-by: Stuart Lee <stuart.lee@mediatek.com>
> Cc: stable@vger.kernel.org
Reviewed-by: AngeloGioacchino DEl Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get
2023-11-10 1:29 ` [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get Stuart Lee
2023-11-10 2:00 ` CK Hu (胡俊光)
2023-11-10 11:57 ` AngeloGioacchino Del Regno
@ 2023-12-11 14:44 ` Chun-Kuang Hu
2 siblings, 0 replies; 5+ messages in thread
From: Chun-Kuang Hu @ 2023-12-11 14:44 UTC (permalink / raw)
To: Stuart Lee
Cc: Chun-Kuang Hu, AngeloGioacchino Del Regno, Philipp Zabel,
David Airlie, Daniel Vetter, Matthias Brugger, Nancy . Lin,
dri-devel, linux-mediatek, linux-kernel, linux-arm-kernel,
Lancelot Wu, Shawn Sung, Pablo Sun, Macpaul Lin, stable
Hi, Stuart:
Stuart Lee <stuart.lee@mediatek.com> 於 2023年11月10日 週五 上午9:29寫道：
>
> Add error handling to check NULL input in
> mtk_drm_crtc_dma_dev_get function.
>
> While display path is not configured correctly, none of crtc is
> established. So the caller of mtk_drm_crtc_dma_dev_get may pass
> input parameter *crtc as NULL, Which may cause coredump when
> we try to get the container of NULL pointer.
Applied to mediatek-drm-fixes [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes
Regards,
Chun-Kuang.
>
> Fixes: cb1d6bcca542 ("drm/mediatek: Add dma dev get function")
> Signed-off-by: Stuart Lee <stuart.lee@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index c277b9fae950..047c9a31d306 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -921,7 +921,14 @@ static int mtk_drm_crtc_init_comp_planes(struct drm_device *drm_dev,
>
> struct device *mtk_drm_crtc_dma_dev_get(struct drm_crtc *crtc)
> {
> - struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
> + struct mtk_drm_crtc *mtk_crtc = NULL;
> +
> + if (!crtc)
> + return NULL;
> +
> + mtk_crtc = to_mtk_crtc(crtc);
> + if (!mtk_crtc)
> + return NULL;
>
> return mtk_crtc->dma_dev;
> }
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread