Re: [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker

Re: [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker

[Johan Hovold]

Hi Greg and Sasha,

On Mon, Dec 04, 2023 at 12:47:34PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Limit the speaker digital gains to 0dB so that the users will not damage them.
> Currently there is a limit in UCM, but this does not stop the user form
> changing the digital gains from command line. So limit this in driver
> which makes the speakers more safer without active speaker protection in
> place.
> 
> Apart from this there is also a range check fix in snd_soc_limit_volume
> to allow setting this limit correctly.
> 
> Tested on Lenovo X13s.
> 
> Srinivas Kandagatla (2):
>   ASoC: ops: add correct range check for limiting volume
>   ASoC: qcom: sc8280xp: Limit speaker digital volumes

These were unfortunately not marked for stable, but could you pick them
up for 6.6?

The upstream commits are:

	fb9ad2448508 ("ASoC: ops: add correct range check for limiting volume")
	716d4e5373e9 ("ASoC: qcom: sc8280xp: Limit speaker digital volumes")

>  sound/soc/qcom/sc8280xp.c | 17 +++++++++++++++++
>  sound/soc/soc-ops.c       |  2 +-
>  2 files changed, 18 insertions(+), 1 deletion(-)

Johan

Re: [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker

[Greg Kroah-Hartman]

On Mon, Dec 11, 2023 at 09:08:03AM +0100, Johan Hovold wrote:
> Hi Greg and Sasha,
> 
> On Mon, Dec 04, 2023 at 12:47:34PM +0000, srinivas.kandagatla@linaro.org wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > 
> > Limit the speaker digital gains to 0dB so that the users will not damage them.
> > Currently there is a limit in UCM, but this does not stop the user form
> > changing the digital gains from command line. So limit this in driver
> > which makes the speakers more safer without active speaker protection in
> > place.
> > 
> > Apart from this there is also a range check fix in snd_soc_limit_volume
> > to allow setting this limit correctly.
> > 
> > Tested on Lenovo X13s.
> > 
> > Srinivas Kandagatla (2):
> >   ASoC: ops: add correct range check for limiting volume
> >   ASoC: qcom: sc8280xp: Limit speaker digital volumes
> 
> These were unfortunately not marked for stable, but could you pick them
> up for 6.6?
> 
> The upstream commits are:
> 
> 	fb9ad2448508 ("ASoC: ops: add correct range check for limiting volume")
> 	716d4e5373e9 ("ASoC: qcom: sc8280xp: Limit speaker digital volumes")

Now queued up, thanks.

greg k-h

Re: [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker

[Greg Kroah-Hartman]

On Mon, Dec 11, 2023 at 01:40:52PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 11, 2023 at 09:08:03AM +0100, Johan Hovold wrote:
> > Hi Greg and Sasha,
> > 
> > On Mon, Dec 04, 2023 at 12:47:34PM +0000, srinivas.kandagatla@linaro.org wrote:
> > > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > > 
> > > Limit the speaker digital gains to 0dB so that the users will not damage them.
> > > Currently there is a limit in UCM, but this does not stop the user form
> > > changing the digital gains from command line. So limit this in driver
> > > which makes the speakers more safer without active speaker protection in
> > > place.
> > > 
> > > Apart from this there is also a range check fix in snd_soc_limit_volume
> > > to allow setting this limit correctly.
> > > 
> > > Tested on Lenovo X13s.
> > > 
> > > Srinivas Kandagatla (2):
> > >   ASoC: ops: add correct range check for limiting volume
> > >   ASoC: qcom: sc8280xp: Limit speaker digital volumes
> > 
> > These were unfortunately not marked for stable, but could you pick them
> > up for 6.6?
> > 
> > The upstream commits are:
> > 
> > 	fb9ad2448508 ("ASoC: ops: add correct range check for limiting volume")
> > 	716d4e5373e9 ("ASoC: qcom: sc8280xp: Limit speaker digital volumes")
> 
> Now queued up, thanks.

Oops, no, this breaks the build on 6.6.y, can you send a series that is
at least built for this series successfully?  :)

thanks,

greg k-h

Re: [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker

[Johan Hovold]

On Mon, Dec 11, 2023 at 01:54:39PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 11, 2023 at 01:40:52PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 11, 2023 at 09:08:03AM +0100, Johan Hovold wrote:
> > > On Mon, Dec 04, 2023 at 12:47:34PM +0000, srinivas.kandagatla@linaro.org wrote:

> > > These were unfortunately not marked for stable, but could you pick them
> > > up for 6.6?
> > > 
> > > The upstream commits are:
> > > 
> > > 	fb9ad2448508 ("ASoC: ops: add correct range check for limiting volume")
> > > 	716d4e5373e9 ("ASoC: qcom: sc8280xp: Limit speaker digital volumes")
> > 
> > Now queued up, thanks.
> 
> Oops, no, this breaks the build on 6.6.y, can you send a series that is
> at least built for this series successfully?  :)

Sorry about that. I was not aware of the asoc interface rename that went
into 6.7.

Just sent a backport of the series here:

	https://lore.kernel.org/r/20231211132608.27861-1-johan+linaro@kernel.org

Johan