From: Greg KH <gregkh@linuxfoundation.org>
To: Fabian Godehardt <fg@emlix.com>
Cc: stable@vger.kernel.org
Subject: Re: [4.19] please include b65ba0c362be665192381cc59e3ac3ef6f0dd1e1
Date: Wed, 20 Dec 2023 15:40:36 +0100 [thread overview]
Message-ID: <2023122014-defendant-breezy-5e93@gregkh> (raw)
In-Reply-To: <20231219075640.163128-1-fg@emlix.com>
On Tue, Dec 19, 2023 at 08:56:41AM +0100, Fabian Godehardt wrote:
> Hi all,
>
> please include b65ba0c362be665192381cc59e3ac3ef6f0dd1e1 also on the
> stable-trees up to v5.10 (i think v5.13 was the first fixed tree).
>
> Serial gadget on AM335X is also affected, breaks with NULL pointer
> references and needs this patch. Here is the patch for the v4.19
> tree, cherry picked and manually applied from original commit
> b65ba0c362be665192381cc59e3ac3ef6f0dd1e1:
>
> >From 483d904168b08cf1497c73516c432bde9ae94055 Mon Sep 17 00:00:00 2001
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Date: Fri, 28 May 2021 16:04:46 +0200
> Subject: [PATCH] usb: musb: fix MUSB_QUIRK_B_DISCONNECT_99 handling
>
> In commit 92af4fc6ec33 ("usb: musb: Fix suspend with devices
> connected for a64"), the logic to support the
> MUSB_QUIRK_B_DISCONNECT_99 quirk was modified to only conditionally
> schedule the musb->irq_work delayed work.
>
> This commit badly breaks ECM Gadget on AM335X. Indeed, with this
> commit, one can observe massive packet loss:
>
> $ ping 192.168.0.100
> ...
> 15 packets transmitted, 3 received, 80% packet loss, time 14316ms
>
> Reverting this commit brings back a properly functioning ECM
> Gadget. An analysis of the commit seems to indicate that a mistake was
> made: the previous code was not falling through into the
> MUSB_QUIRK_B_INVALID_VBUS_91, but now it is, unless the condition is
> taken.
>
> Changing the logic to be as it was before the problematic commit *and*
> only conditionally scheduling musb->irq_work resolves the regression:
>
> $ ping 192.168.0.100
> ...
> 64 packets transmitted, 64 received, 0% packet loss, time 64475ms
>
> Fixes: 92af4fc6ec33 ("usb: musb: Fix suspend with devices connected for a64")
> Cc: stable@vger.kernel.org
> Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Tested-by: Drew Fustini <drew@beagleboard.org>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Link: https://lore.kernel.org/r/20210528140446.278076-1-thomas.petazzoni@bootlin.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
As you did the backport, you too need to sign off on this. Can you
resend this with that properly added?
thanks,
greg k-h
next prev parent reply other threads:[~2023-12-20 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 7:56 [4.19] please include b65ba0c362be665192381cc59e3ac3ef6f0dd1e1 Fabian Godehardt
2023-12-20 14:40 ` Greg KH [this message]
2023-12-21 5:45 ` Fabian Godehardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023122014-defendant-breezy-5e93@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=fg@emlix.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox