Linux kernel -stable discussions
 help / color / mirror / Atom feed
* Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
@ 2024-04-01 14:09 Bagas Sanjaya
  2024-04-01 14:15 ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Bagas Sanjaya @ 2024-04-01 14:09 UTC (permalink / raw)
  To: Viktor Malik, Andrii Nakryiko, Daniel Xu, Alexei Starovoitov,
	Nick Desaulniers, ncopa
  Cc: Linux Kernel Mailing List, Linux Regressions, Linux Stable

[-- Attachment #1: Type: text/plain, Size: 2931 bytes --]

Hi,

On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
on musl system [1]:

> The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> 
> ```
> rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> In file included from main.c:73:
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
>     7 |         u32 cnt;                                                              
>       |         ^~~                
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
>     8 |         u32 ids[];         
>       |         ^~~                    
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
>    12 |         u32 cnt;   
>       |         ^~~                        
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
>    13 |         u32 flags;
>       |         ^~~
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
>    15 |                 u32 id;
>       |                 ^~~
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
>    16 |                 u32 flags;
>       |                 ^~~
> /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
>   215 | extern u32 btf_tracing_ids[];
>       |        ^~~
> make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> /main.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> ```

Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
Refactor set sorting with types from btf_ids.h") as the culprit.

See the report on Bugzilla for the full thread and proposed fix.

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218647

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 14:09 Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32' Bagas Sanjaya
@ 2024-04-01 14:15 ` Greg KH
  2024-04-01 14:26   ` Bagas Sanjaya
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2024-04-01 14:15 UTC (permalink / raw)
  To: Bagas Sanjaya
  Cc: Viktor Malik, Andrii Nakryiko, Daniel Xu, Alexei Starovoitov,
	Nick Desaulniers, ncopa, Linux Kernel Mailing List,
	Linux Regressions, Linux Stable

On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:
> Hi,
> 
> On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> on musl system [1]:
> 
> > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > 
> > ```
> > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > In file included from main.c:73:
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> >     7 |         u32 cnt;                                                              
> >       |         ^~~                
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> >     8 |         u32 ids[];         
> >       |         ^~~                    
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> >    12 |         u32 cnt;   
> >       |         ^~~                        
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> >    13 |         u32 flags;
> >       |         ^~~
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> >    15 |                 u32 id;
> >       |                 ^~~
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> >    16 |                 u32 flags;
> >       |                 ^~~
> > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> >   215 | extern u32 btf_tracing_ids[];
> >       |        ^~~
> > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > /main.o] Error 1
> > make[4]: *** Waiting for unfinished jobs....
> > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > ```
> 
> Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> Refactor set sorting with types from btf_ids.h") as the culprit.
> 
> See the report on Bugzilla for the full thread and proposed fix.

Is the proposed fix a commit to backport?

Digging through entries is not the easiest way to get things resolved...

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 14:15 ` Greg KH
@ 2024-04-01 14:26   ` Bagas Sanjaya
  2024-04-01 14:36     ` Greg Thelen
  2024-04-01 15:09     ` Fwd: " Alexei Starovoitov
  0 siblings, 2 replies; 7+ messages in thread
From: Bagas Sanjaya @ 2024-04-01 14:26 UTC (permalink / raw)
  To: Greg KH
  Cc: Viktor Malik, Andrii Nakryiko, Daniel Xu, Alexei Starovoitov,
	Nick Desaulniers, ncopa, Linux Kernel Mailing List,
	Linux Regressions, Linux Stable

[-- Attachment #1: Type: text/plain, Size: 3528 bytes --]

On Mon, Apr 01, 2024 at 04:15:25PM +0200, Greg KH wrote:
> On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:
> > Hi,
> > 
> > On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> > on musl system [1]:
> > 
> > > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > > 
> > > ```
> > > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > > In file included from main.c:73:
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> > >     7 |         u32 cnt;                                                              
> > >       |         ^~~                
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> > >     8 |         u32 ids[];         
> > >       |         ^~~                    
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> > >    12 |         u32 cnt;   
> > >       |         ^~~                        
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> > >    13 |         u32 flags;
> > >       |         ^~~
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> > >    15 |                 u32 id;
> > >       |                 ^~~
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> > >    16 |                 u32 flags;
> > >       |                 ^~~
> > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> > >   215 | extern u32 btf_tracing_ids[];
> > >       |        ^~~
> > > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > > /main.o] Error 1
> > > make[4]: *** Waiting for unfinished jobs....
> > > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > > ```
> > 
> > Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> > Refactor set sorting with types from btf_ids.h") as the culprit.
> > 
> > See the report on Bugzilla for the full thread and proposed fix.
> 
> Is the proposed fix a commit to backport?

Nope (see below).

> 
> Digging through entries is not the easiest way to get things resolved...
> 

The reporter posted the fix as bug comment [1] instead (hint: include
linux/types.h) but not submitted it to mailing lists first.

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218647#c2

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 14:26   ` Bagas Sanjaya
@ 2024-04-01 14:36     ` Greg Thelen
  2024-04-01 15:27       ` Natanael Copa
  2024-04-01 15:09     ` Fwd: " Alexei Starovoitov
  1 sibling, 1 reply; 7+ messages in thread
From: Greg Thelen @ 2024-04-01 14:36 UTC (permalink / raw)
  To: Bagas Sanjaya
  Cc: Greg KH, Viktor Malik, Andrii Nakryiko, Daniel Xu,
	Alexei Starovoitov, Nick Desaulniers, ncopa,
	Linux Kernel Mailing List, Linux Regressions, Linux Stable

On Mon, Apr 1, 2024 at 7:26 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Mon, Apr 01, 2024 at 04:15:25PM +0200, Greg KH wrote:
> > On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:
> > > Hi,
> > >
> > > On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> > > on musl system [1]:
> > >
> > > > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > > >
> > > > ```
> > > > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > > > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > > > In file included from main.c:73:
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> > > >     7 |         u32 cnt;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> > > >     8 |         u32 ids[];
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> > > >    12 |         u32 cnt;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> > > >    13 |         u32 flags;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> > > >    15 |                 u32 id;
> > > >       |                 ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> > > >    16 |                 u32 flags;
> > > >       |                 ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> > > >   215 | extern u32 btf_tracing_ids[];
> > > >       |        ^~~
> > > > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > > > /main.o] Error 1
> > > > make[4]: *** Waiting for unfinished jobs....
> > > > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > > > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > > > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > > > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > > > ```
> > >
> > > Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> > > Refactor set sorting with types from btf_ids.h") as the culprit.
> > >
> > > See the report on Bugzilla for the full thread and proposed fix.
> >
> > Is the proposed fix a commit to backport?
>
> Nope (see below).
>
> >
> > Digging through entries is not the easiest way to get things resolved...
> >
>
> The reporter posted the fix as bug comment [1] instead (hint: include
> linux/types.h) but not submitted it to mailing lists first.
>
> Thanks.
>
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218647#c2
>
> --
> An old man doll... just what I always wanted! - Clara

Does https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
resolve this? It's staged in the bpf tree. Though I'm not sure when
it'll be merged upstream.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 14:26   ` Bagas Sanjaya
  2024-04-01 14:36     ` Greg Thelen
@ 2024-04-01 15:09     ` Alexei Starovoitov
  2024-04-01 15:24       ` Greg KH
  1 sibling, 1 reply; 7+ messages in thread
From: Alexei Starovoitov @ 2024-04-01 15:09 UTC (permalink / raw)
  To: Bagas Sanjaya
  Cc: Greg KH, Viktor Malik, Andrii Nakryiko, Daniel Xu,
	Alexei Starovoitov, Nick Desaulniers, Natanael Copa,
	Linux Kernel Mailing List, Linux Regressions, Linux Stable

On Mon, Apr 1, 2024 at 7:26 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Mon, Apr 01, 2024 at 04:15:25PM +0200, Greg KH wrote:
> > On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:
> > > Hi,
> > >
> > > On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> > > on musl system [1]:
> > >
> > > > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > > >
> > > > ```
> > > > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > > > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > > > In file included from main.c:73:
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> > > >     7 |         u32 cnt;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> > > >     8 |         u32 ids[];
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> > > >    12 |         u32 cnt;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> > > >    13 |         u32 flags;
> > > >       |         ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> > > >    15 |                 u32 id;
> > > >       |                 ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> > > >    16 |                 u32 flags;
> > > >       |                 ^~~
> > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> > > >   215 | extern u32 btf_tracing_ids[];
> > > >       |        ^~~
> > > > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > > > /main.o] Error 1
> > > > make[4]: *** Waiting for unfinished jobs....

> > > > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > > > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > > > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > > > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > > > ```
> > >
> > > Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> > > Refactor set sorting with types from btf_ids.h") as the culprit.
> > >
> > > See the report on Bugzilla for the full thread and proposed fix.
> >
> > Is the proposed fix a commit to backport?
>
> Nope (see below).

The fix is in bpf tree.
commit 62248b22d01e ("tools/resolve_btfids: fix build with musl libc")

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 15:09     ` Fwd: " Alexei Starovoitov
@ 2024-04-01 15:24       ` Greg KH
  0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2024-04-01 15:24 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Bagas Sanjaya, Viktor Malik, Andrii Nakryiko, Daniel Xu,
	Alexei Starovoitov, Nick Desaulniers, Natanael Copa,
	Linux Kernel Mailing List, Linux Regressions, Linux Stable

On Mon, Apr 01, 2024 at 08:09:40AM -0700, Alexei Starovoitov wrote:
> On Mon, Apr 1, 2024 at 7:26 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Mon, Apr 01, 2024 at 04:15:25PM +0200, Greg KH wrote:
> > > On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:
> > > > Hi,
> > > >
> > > > On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> > > > on musl system [1]:
> > > >
> > > > > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > > > >
> > > > > ```
> > > > > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > > > > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > > > > In file included from main.c:73:
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> > > > >     7 |         u32 cnt;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> > > > >     8 |         u32 ids[];
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> > > > >    12 |         u32 cnt;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> > > > >    13 |         u32 flags;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> > > > >    15 |                 u32 id;
> > > > >       |                 ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> > > > >    16 |                 u32 flags;
> > > > >       |                 ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> > > > >   215 | extern u32 btf_tracing_ids[];
> > > > >       |        ^~~
> > > > > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > > > > /main.o] Error 1
> > > > > make[4]: *** Waiting for unfinished jobs....
> 
> > > > > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > > > > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > > > > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > > > > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > > > > ```
> > > >
> > > > Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> > > > Refactor set sorting with types from btf_ids.h") as the culprit.
> > > >
> > > > See the report on Bugzilla for the full thread and proposed fix.
> > >
> > > Is the proposed fix a commit to backport?
> >
> > Nope (see below).
> 
> The fix is in bpf tree.
> commit 62248b22d01e ("tools/resolve_btfids: fix build with musl libc")

Thanks, I'll go queue that up now to make people's lives easier.

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32'
  2024-04-01 14:36     ` Greg Thelen
@ 2024-04-01 15:27       ` Natanael Copa
  0 siblings, 0 replies; 7+ messages in thread
From: Natanael Copa @ 2024-04-01 15:27 UTC (permalink / raw)
  To: Greg Thelen
  Cc: Bagas Sanjaya, Greg KH, Viktor Malik, Andrii Nakryiko, Daniel Xu,
	Alexei Starovoitov, Nick Desaulniers, Linux Kernel Mailing List,
	Linux Regressions, Linux Stable

On Mon, 1 Apr 2024 07:36:08 -0700
Greg Thelen <gthelen@google.com> wrote:

> On Mon, Apr 1, 2024 at 7:26*AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Mon, Apr 01, 2024 at 04:15:25PM +0200, Greg KH wrote:  
> > > On Mon, Apr 01, 2024 at 09:09:55PM +0700, Bagas Sanjaya wrote:  
> > > > Hi,
> > > >
> > > > On Bugzilla, ncopa@alpinelinux.org reported resolve_btfids FTBFS regression
> > > > on musl system [1]:
> > > >  
> > > > > The latest releases fails to build with musl libc (Alpine Linux edge and v3.19):
> > > > >
> > > > > ```
> > > > > rm -f -f /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/libbpf.a; ar rcs /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tool
> > > > > s/bpf/resolve_btfids/libbpf/libbpf.a /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids/libbpf/staticobjs/libbpf-in.o
> > > > > In file included from main.c:73:
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:7:9: error: unknown type name 'u32'
> > > > >     7 |         u32 cnt;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:8:9: error: unknown type name 'u32'
> > > > >     8 |         u32 ids[];
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:12:9: error: unknown type name 'u32'
> > > > >    12 |         u32 cnt;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:13:9: error: unknown type name 'u32'
> > > > >    13 |         u32 flags;
> > > > >       |         ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:15:17: error: unknown type name 'u32'
> > > > >    15 |                 u32 id;
> > > > >       |                 ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:16:17: error: unknown type name 'u32'
> > > > >    16 |                 u32 flags;
> > > > >       |                 ^~~
> > > > > /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/btf_ids.h:215:8: error: unknown type name 'u32'
> > > > >   215 | extern u32 btf_tracing_ids[];
> > > > >       |        ^~~
> > > > > make[4]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids
> > > > > /main.o] Error 1
> > > > > make[4]: *** Waiting for unfinished jobs....
> > > > > make[3]: *** [Makefile:83: /home/ncopa/aports/main/linux-lts/src/build-lts.x86_64/tools/bpf/resolve_btfids//resolve_btfids-in.o] Error 2
> > > > > make[2]: *** [Makefile:76: bpf/resolve_btfids] Error 2
> > > > > make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1354: tools/bpf/resolve_btfids] Error 2
> > > > > make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2
> > > > > ```  
> > > >
> > > > Bisection led to upstream commit 9707ac4fe2f5ba ("tools/resolve_btfids:
> > > > Refactor set sorting with types from btf_ids.h") as the culprit.
> > > >
> > > > See the report on Bugzilla for the full thread and proposed fix.  
> > >
> > > Is the proposed fix a commit to backport?  
> >
> > Nope (see below).
> >  
> > >
> > > Digging through entries is not the easiest way to get things resolved...
> > >  
> >
> > The reporter posted the fix as bug comment [1] instead (hint: include
> > linux/types.h) but not submitted it to mailing lists first.
> >
> > Thanks.
> >
> > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218647#c2
> >
> > --
> > An old man doll... just what I always wanted! - Clara  
> 
> Does https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
> resolve this? It's staged in the bpf tree. Though I'm not sure when
> it'll be merged upstream.

Yes. this is the fix

-nc

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-04-01 15:27 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 14:09 Fwd: stable kernels 6.6.23 and 6.1.83 fails to build: error: unknown type name 'u32' Bagas Sanjaya
2024-04-01 14:15 ` Greg KH
2024-04-01 14:26   ` Bagas Sanjaya
2024-04-01 14:36     ` Greg Thelen
2024-04-01 15:27       ` Natanael Copa
2024-04-01 15:09     ` Fwd: " Alexei Starovoitov
2024-04-01 15:24       ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox