* Re: [PATCH net] net: sfp-bus: fix SFP mode detect from bitrate [not found] ` <ZaVYKgCPZaidGimU@shell.armlinux.org.uk> @ 2024-05-30 10:39 ` Daniel Golle 2024-06-12 12:33 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Daniel Golle @ 2024-05-30 10:39 UTC (permalink / raw) To: stable Cc: Russell King (Oracle), Maxime Chevallier, Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman, netdev Hi stable team, > > On Mon, 15 Jan 2024 12:43:38 +0000 > > "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > > > > > The referenced commit moved the setting of the Autoneg and pause bits > > > early in sfp_parse_support(). However, we check whether the modes are > > > empty before using the bitrate to set some modes. Setting these bits > > > so early causes that test to always be false, preventing this working, > > > and thus some modules that used to work no longer do. > > > > > > Move them just before the call to the quirk. > > > > > > Fixes: 8110633db49d ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits") > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> please apply this patch also to Linux stable down to v6.4 which are affected by problems introduced by commit 8110633db49d ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits"). The fix has been applied to net tree as commit 97eb5d51b4a5 ("net: sfp-bus: fix SFP mode detect from bitrate") but never picked for older kernel versions affected as well. Thank you! Daniel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: sfp-bus: fix SFP mode detect from bitrate 2024-05-30 10:39 ` [PATCH net] net: sfp-bus: fix SFP mode detect from bitrate Daniel Golle @ 2024-06-12 12:33 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2024-06-12 12:33 UTC (permalink / raw) To: Daniel Golle Cc: stable, Russell King (Oracle), Maxime Chevallier, Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman, netdev On Thu, May 30, 2024 at 11:39:55AM +0100, Daniel Golle wrote: > Hi stable team, > > > > On Mon, 15 Jan 2024 12:43:38 +0000 > > > "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > > > > > > > The referenced commit moved the setting of the Autoneg and pause bits > > > > early in sfp_parse_support(). However, we check whether the modes are > > > > empty before using the bitrate to set some modes. Setting these bits > > > > so early causes that test to always be false, preventing this working, > > > > and thus some modules that used to work no longer do. > > > > > > > > Move them just before the call to the quirk. > > > > > > > > Fixes: 8110633db49d ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits") > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > please apply this patch also to Linux stable down to v6.4 which are > affected by problems introduced by commit 8110633db49d ("net: sfp-bus: > allow SFP quirks to override Autoneg and pause bits"). > > The fix has been applied to net tree as commit 97eb5d51b4a5 ("net: > sfp-bus: fix SFP mode detect from bitrate") but never picked for older > kernel versions affected as well. Ok, applied to 6.6 only. greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-12 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1rPMJW-001Ahf-L0@rmk-PC.armlinux.org.uk>
[not found] ` <20240115165848.110ad8f9@device-28.home>
[not found] ` <ZaVYKgCPZaidGimU@shell.armlinux.org.uk>
2024-05-30 10:39 ` [PATCH net] net: sfp-bus: fix SFP mode detect from bitrate Daniel Golle
2024-06-12 12:33 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox