From: Greg KH <gregkh@linuxfoundation.org>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: stable@vger.kernel.org, syzbot <syzkaller@googlegroups.com>,
"Eric Dumazet" <edumazet@google.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jakub Kicinski" <kuba@kernel.org>
Subject: Re: [PATCH stable 4.19] xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING
Date: Wed, 12 Jun 2024 16:40:33 +0200 [thread overview]
Message-ID: <2024061258-research-tractor-159b@gregkh> (raw)
In-Reply-To: <20240606034835.19936-1-shung-hsi.yu@suse.com>
On Thu, Jun 06, 2024 at 11:48:33AM +0800, Shung-Hsi Yu wrote:
> Two additional changes not present in the original patch:
> 1. Check optlen in the XDP_UMEM_REG case as well. It was added in commit
> c05cd36458147 ("xsk: add support to allow unaligned chunk placement")
> but seems like too big of a change for stable
> 2. copy_from_sockptr() in the context was replace copy_from_usr()
> because commit a7b75c5a8c414 ("net: pass a sockptr_t into
> ->setsockopt") was not present
>
> [ Upstream commit 237f3cf13b20db183d3706d997eedc3c49eacd44 ]
What about 5.4.y? We can't take a patch in an older stable tree and
have a regression when someone moves to a new one, right?
I'll drop this for now and wait for a backport for both trees before
applying it.
thanks,
greg k-h
next prev parent reply other threads:[~2024-06-12 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 3:48 [PATCH stable 4.19] xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING Shung-Hsi Yu
2024-06-12 14:40 ` Greg KH [this message]
2024-06-13 1:13 ` Shung-Hsi Yu
2024-06-13 8:33 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-06-13 12:24 Shung-Hsi Yu
2024-06-17 12:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061258-research-tractor-159b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bjorn@kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=shung-hsi.yu@suse.com \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox