Re: [PATCH stable 4.19] xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jun 13, 2024 at 09:13:57AM +0800, Shung-Hsi Yu wrote:
> On Wed, Jun 12, 2024 at 04:40:33PM GMT, Greg KH wrote:
> > On Thu, Jun 06, 2024 at 11:48:33AM +0800, Shung-Hsi Yu wrote:
> > > Two additional changes not present in the original patch:
> > > 1. Check optlen in the XDP_UMEM_REG case as well. It was added in commit
> > >    c05cd36458147 ("xsk: add support to allow unaligned chunk placement")
> > >    but seems like too big of a change for stable
> > > 2. copy_from_sockptr() in the context was replace copy_from_usr()
> > >    because commit a7b75c5a8c414 ("net: pass a sockptr_t into
> > >    ->setsockopt") was not present
> > > 
> > > [ Upstream commit 237f3cf13b20db183d3706d997eedc3c49eacd44 ]
> > 
> > What about 5.4.y?  We can't take a patch in an older stable tree and
> > have a regression when someone moves to a new one, right?
> > 
> > I'll drop this for now and wait for a backport for both trees before
> > applying it.
> 
> I somehow though I've checked that 5.4 contains the fix, but apparently
> not. Will send backoprt for 5.4 as well.

Thanks, but please resend this commit as it is long gone from my tree...