From: Greg KH <greg@kroah.com>
To: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
jlayton@kernel.org, Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: Patch "nfsd: fix oops when reading pool_stats before server is started" has been added to the 6.9-stable tree
Date: Tue, 25 Jun 2024 07:42:44 +0200 [thread overview]
Message-ID: <2024062537-overtone-cupping-3f13@gregkh> (raw)
In-Reply-To: <171926974436.14261.14452569082069214699@noble.neil.brown.name>
On Tue, Jun 25, 2024 at 08:55:44AM +1000, NeilBrown wrote:
> On Mon, 24 Jun 2024, stable@vger.kernel.org wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > nfsd: fix oops when reading pool_stats before server is started
> >
> > to the 6.9-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > nfsd-fix-oops-when-reading-pool_stats-before-server-.patch
> > and it can be found in the queue-6.9 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
>
> I feel this should not be added to the stable tree.
>
> It moves at test on a field protected by a mutex outside of the
> protection of that mutex, and so is obviously racey.
>
> Depending on how the race goes, si->serv might be NULL when dereferenced
> in svc_pool_stats_start(), or svc_pool_stats_stop() might unlock a mutex
> that hadn't been locked.
>
> I'll post a revert and a better fix for mainline.
Now dropped, thanks!
greg k-h
prev parent reply other threads:[~2024-06-25 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240624134957.936227-1-sashal@kernel.org>
2024-06-24 22:55 ` Patch "nfsd: fix oops when reading pool_stats before server is started" has been added to the 6.9-stable tree NeilBrown
2024-06-25 5:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024062537-overtone-cupping-3f13@gregkh \
--to=greg@kroah.com \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=neilb@suse.de \
--cc=pabeni@redhat.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox