* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree [not found] <2024062436-wrist-skier-47a6@gregkh> @ 2024-06-25 6:28 ` Martin Schiller 2024-06-25 6:33 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Martin Schiller @ 2024-06-25 6:28 UTC (permalink / raw) To: gregkh; +Cc: tsbogend, stable On 2024-06-24 19:01, gregkh@linuxfoundation.org wrote: > This is a note to let you know that I've just added the patch titled > > MIPS: pci: lantiq: restore reset gpio polarity > > to the 6.9-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > mips-pci-lantiq-restore-reset-gpio-polarity.patch > and it can be found in the queue-6.9 subdirectory. > > If you, or anyone else, feels it should not be added to the stable > tree, > please let <stable@vger.kernel.org> know about it. This patch is buggy and should not go into the stable trees. It has already been reverted upstream in the mips-fixes. Thank you very much and sorry for the inconvenience, Martin > > > From 277a0363120276645ae598d8d5fea7265e076ae9 Mon Sep 17 00:00:00 2001 > From: Martin Schiller <ms@dev.tdt.de> > Date: Fri, 7 Jun 2024 11:04:00 +0200 > Subject: MIPS: pci: lantiq: restore reset gpio polarity > > From: Martin Schiller <ms@dev.tdt.de> > > commit 277a0363120276645ae598d8d5fea7265e076ae9 upstream. > > Commit 90c2d2eb7ab5 ("MIPS: pci: lantiq: switch to using gpiod API") > not > only switched to the gpiod API, but also inverted / changed the > polarity > of the GPIO. > > According to the PCI specification, the RST# pin is an active-low > signal. However, most of the device trees that have been widely used > for > a long time (mainly in the openWrt project) define this GPIO as > active-high and the old driver code inverted the signal internally. > > Apparently there are actually boards where the reset gpio must be > operated inverted. For this reason, we cannot use the > GPIOD_OUT_LOW/HIGH > flag for initialization. Instead, we must explicitly set the gpio to > value 1 in order to take into account any "GPIO_ACTIVE_LOW" flag that > may have been set. > > In order to remain compatible with all these existing device trees, we > should therefore keep the logic as it was before the commit. > > Fixes: 90c2d2eb7ab5 ("MIPS: pci: lantiq: switch to using gpiod API") > Cc: stable@vger.kernel.org > Signed-off-by: Martin Schiller <ms@dev.tdt.de> > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > arch/mips/pci/pci-lantiq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- a/arch/mips/pci/pci-lantiq.c > +++ b/arch/mips/pci/pci-lantiq.c > @@ -124,14 +124,14 @@ static int ltq_pci_startup(struct platfo > clk_disable(clk_external); > > /* setup reset gpio used by pci */ > - reset_gpio = devm_gpiod_get_optional(&pdev->dev, "reset", > - GPIOD_OUT_LOW); > + reset_gpio = devm_gpiod_get_optional(&pdev->dev, "reset", > GPIOD_ASIS); > error = PTR_ERR_OR_ZERO(reset_gpio); > if (error) { > dev_err(&pdev->dev, "failed to request gpio: %d\n", error); > return error; > } > gpiod_set_consumer_name(reset_gpio, "pci_reset"); > + gpiod_direction_output(reset_gpio, 1); > > /* enable auto-switching between PCI and EBU */ > ltq_pci_w32(0xa, PCI_CR_CLK_CTRL); > @@ -194,10 +194,10 @@ static int ltq_pci_startup(struct platfo > > /* toggle reset pin */ > if (reset_gpio) { > - gpiod_set_value_cansleep(reset_gpio, 1); > + gpiod_set_value_cansleep(reset_gpio, 0); > wmb(); > mdelay(1); > - gpiod_set_value_cansleep(reset_gpio, 0); > + gpiod_set_value_cansleep(reset_gpio, 1); > } > return 0; > } > > > Patches currently in stable-queue which might be from ms@dev.tdt.de are > > queue-6.9/mips-pci-lantiq-restore-reset-gpio-polarity.patch ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree 2024-06-25 6:28 ` Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree Martin Schiller @ 2024-06-25 6:33 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2024-06-25 6:33 UTC (permalink / raw) To: Martin Schiller; +Cc: tsbogend, stable On Tue, Jun 25, 2024 at 08:28:25AM +0200, Martin Schiller wrote: > On 2024-06-24 19:01, gregkh@linuxfoundation.org wrote: > > This is a note to let you know that I've just added the patch titled > > > > MIPS: pci: lantiq: restore reset gpio polarity > > > > to the 6.9-stable tree which can be found at: > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > mips-pci-lantiq-restore-reset-gpio-polarity.patch > > and it can be found in the queue-6.9 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@vger.kernel.org> know about it. > > > This patch is buggy and should not go into the stable trees. > It has already been reverted upstream in the mips-fixes. > > Thank you very much and sorry for the inconvenience, Thanks for letting us know, now dropped. greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20240627185200.2305691-1-sashal@kernel.org>]
* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree [not found] <20240627185200.2305691-1-sashal@kernel.org> @ 2024-06-28 6:55 ` Thomas Bogendoerfer 2024-06-28 14:18 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Thomas Bogendoerfer @ 2024-06-28 6:55 UTC (permalink / raw) To: stable; +Cc: stable-commits, ms On Thu, Jun 27, 2024 at 02:52:00PM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > MIPS: pci: lantiq: restore reset gpio polarity > > to the 6.9-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > mips-pci-lantiq-restore-reset-gpio-polarity.patch > and it can be found in the queue-6.9 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@vger.kernel.org> know about it. can you drop this patch from _all_ stable patches, it was reverted already in the pull-request to Linus. Thank you. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree 2024-06-28 6:55 ` Thomas Bogendoerfer @ 2024-06-28 14:18 ` Greg KH 2024-06-28 15:29 ` Thomas Bogendoerfer 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2024-06-28 14:18 UTC (permalink / raw) To: Thomas Bogendoerfer; +Cc: stable, stable-commits, ms On Fri, Jun 28, 2024 at 08:55:38AM +0200, Thomas Bogendoerfer wrote: > On Thu, Jun 27, 2024 at 02:52:00PM -0400, Sasha Levin wrote: > > This is a note to let you know that I've just added the patch titled > > > > MIPS: pci: lantiq: restore reset gpio polarity > > > > to the 6.9-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > mips-pci-lantiq-restore-reset-gpio-polarity.patch > > and it can be found in the queue-6.9 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@vger.kernel.org> know about it. > > can you drop this patch from _all_ stable patches, it was reverted already > in the pull-request to Linus. Thank you. What is the git id of the revert? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree 2024-06-28 14:18 ` Greg KH @ 2024-06-28 15:29 ` Thomas Bogendoerfer 2024-07-01 12:24 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Thomas Bogendoerfer @ 2024-06-28 15:29 UTC (permalink / raw) To: Greg KH; +Cc: stable, stable-commits, ms On Fri, Jun 28, 2024 at 04:18:37PM +0200, Greg KH wrote: > On Fri, Jun 28, 2024 at 08:55:38AM +0200, Thomas Bogendoerfer wrote: > > On Thu, Jun 27, 2024 at 02:52:00PM -0400, Sasha Levin wrote: > > > This is a note to let you know that I've just added the patch titled > > > > > > MIPS: pci: lantiq: restore reset gpio polarity > > > > > > to the 6.9-stable tree which can be found at: > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > mips-pci-lantiq-restore-reset-gpio-polarity.patch > > > and it can be found in the queue-6.9 subdirectory. > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > please let <stable@vger.kernel.org> know about it. > > > > can you drop this patch from _all_ stable patches, it was reverted already > > in the pull-request to Linus. Thank you. > > What is the git id of the revert? 6e5aee08bd25 (tag: mips-fixes_6.10_1) Revert "MIPS: pci: lantiq: restore reset gpio polarity" Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree 2024-06-28 15:29 ` Thomas Bogendoerfer @ 2024-07-01 12:24 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2024-07-01 12:24 UTC (permalink / raw) To: Thomas Bogendoerfer; +Cc: stable, stable-commits, ms On Fri, Jun 28, 2024 at 05:29:49PM +0200, Thomas Bogendoerfer wrote: > On Fri, Jun 28, 2024 at 04:18:37PM +0200, Greg KH wrote: > > On Fri, Jun 28, 2024 at 08:55:38AM +0200, Thomas Bogendoerfer wrote: > > > On Thu, Jun 27, 2024 at 02:52:00PM -0400, Sasha Levin wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > > > > > MIPS: pci: lantiq: restore reset gpio polarity > > > > > > > > to the 6.9-stable tree which can be found at: > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > > > The filename of the patch is: > > > > mips-pci-lantiq-restore-reset-gpio-polarity.patch > > > > and it can be found in the queue-6.9 subdirectory. > > > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > > please let <stable@vger.kernel.org> know about it. > > > > > > can you drop this patch from _all_ stable patches, it was reverted already > > > in the pull-request to Linus. Thank you. > > > > What is the git id of the revert? > > 6e5aee08bd25 (tag: mips-fixes_6.10_1) Revert "MIPS: pci: lantiq: restore reset gpio polarity" Now queued up, thanks. greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-01 12:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2024062436-wrist-skier-47a6@gregkh>
2024-06-25 6:28 ` Patch "MIPS: pci: lantiq: restore reset gpio polarity" has been added to the 6.9-stable tree Martin Schiller
2024-06-25 6:33 ` Greg KH
[not found] <20240627185200.2305691-1-sashal@kernel.org>
2024-06-28 6:55 ` Thomas Bogendoerfer
2024-06-28 14:18 ` Greg KH
2024-06-28 15:29 ` Thomas Bogendoerfer
2024-07-01 12:24 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox