* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem [not found] ` <20240723041136.GC3222663@mit.edu> @ 2024-07-23 10:04 ` Thorsten Leemhuis 2024-07-23 11:14 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Thorsten Leemhuis @ 2024-07-23 10:04 UTC (permalink / raw) To: Greg KH, stable@vger.kernel.org Cc: Darrick J. Wong, Artem S. Tashkinov, Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer, justinstitt, keescook, linux-hardening, Theodore Ts'o, Kees Cook, Linux kernel regressions list On 23.07.24 06:11, Theodore Ts'o wrote: > On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote: >>> Is strscpy_pad appropriate if the @src parameter itself is a fixed >>> length char[16] which isn't null terminated when the label itself is 16 >>> chars long? >> >> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef > > Yeah, sorry, I was on vacation for 3.5 weeks starting just before > Memorial day, and it took me a while to get caught up. Unfortunately, > I missed the bug in the strncpy extirpation patch, and it was't > something that our regression tests caught. (Sometimes, the > old/deprecated ways are just more reliable; all of ext4's strncpy() > calls were working and had been correct for decades. :-P ) > > Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be > making its way to -stable. Adding Greg and the stable list to the list of recipients: given that we already have two reports about trouble due to this[1] he might want to fast-track the fix (be27cd64461c45 ("ext4: use memtostr_pad() for s_volume_name")) to 6.10.y, as it's not queued yet -- at least afaics from looking at https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ Ciao, Thorsten [1] https://bugzilla.kernel.org/show_bug.cgi?id=219072 and https://bugzilla.kernel.org/show_bug.cgi?id=219078 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem 2024-07-23 10:04 ` Linux 6.10 regression resulting in a crash when using an ext4 filesystem Thorsten Leemhuis @ 2024-07-23 11:14 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2024-07-23 11:14 UTC (permalink / raw) To: Thorsten Leemhuis Cc: stable@vger.kernel.org, Darrick J. Wong, Artem S. Tashkinov, Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer, justinstitt, keescook, linux-hardening, Theodore Ts'o, Kees Cook, Linux kernel regressions list On Tue, Jul 23, 2024 at 12:04:41PM +0200, Thorsten Leemhuis wrote: > On 23.07.24 06:11, Theodore Ts'o wrote: > > On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote: > >>> Is strscpy_pad appropriate if the @src parameter itself is a fixed > >>> length char[16] which isn't null terminated when the label itself is 16 > >>> chars long? > >> > >> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed: > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef > > > > Yeah, sorry, I was on vacation for 3.5 weeks starting just before > > Memorial day, and it took me a while to get caught up. Unfortunately, > > I missed the bug in the strncpy extirpation patch, and it was't > > something that our regression tests caught. (Sometimes, the > > old/deprecated ways are just more reliable; all of ext4's strncpy() > > calls were working and had been correct for decades. :-P ) > > > > Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be > > making its way to -stable. > > Adding Greg and the stable list to the list of recipients: given that we > already have two reports about trouble due to this[1] he might want to > fast-track the fix (be27cd64461c45 ("ext4: use memtostr_pad() for > s_volume_name")) to 6.10.y, as it's not queued yet -- at least afaics > from looking at > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ Now queued up. And as it was not explicitly marked for stable inclusion, thank you for asking for it to be added. I'll go push out a 6.10.1-rc1 in a short bit with this important fix. thanks, greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-23 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <500f38b2-ad30-4161-8065-a10e53bf1b02@gmx.com>
[not found] ` <20240722041924.GB103010@frogsfrogsfrogs>
[not found] ` <BEEA84E0-1CF5-4F06-BC5C-A0F97240D76D@kernel.org>
[not found] ` <20240723041136.GC3222663@mit.edu>
2024-07-23 10:04 ` Linux 6.10 regression resulting in a crash when using an ext4 filesystem Thorsten Leemhuis
2024-07-23 11:14 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox