backport "udf: Allocate name buffer in directory iterator on heap" to 5.15

backport "udf: Allocate name buffer in directory iterator on heap" to 5.15

[Hauke Mehrtens]

Hi,

I am running into this compile error in 5.15.171 in OpenWrt on 32 bit 
systems. This problem was introduced with kernel 5.15.169.
```
fs/udf/namei.c: In function 'udf_rename':
fs/udf/namei.c:878:1: error: the frame size of 1144 bytes is larger than 
1024 bytes [-Werror=frame-larger-than=]
   878 | }
       | ^
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:289: fs/udf/namei.o] Error 1
make[1]: *** [scripts/Makefile.build:552: fs/udf] Error 2
```

This is fixed by this upstream commit:
commit 0aba4860b0d0216a1a300484ff536171894d49d8
Author: Jan Kara <jack@suse.cz>
Date:   Tue Dec 20 12:38:45 2022 +0100

     udf: Allocate name buffer in directory iterator on heap


Please backport this patch to 5.15 too.
It was already backported to kernel 6.1.

Hauke

Re: backport "udf: Allocate name buffer in directory iterator on heap" to 5.15

[Greg KH]

On Sun, Nov 10, 2024 at 06:36:08PM +0100, Hauke Mehrtens wrote:
> Hi,
> 
> I am running into this compile error in 5.15.171 in OpenWrt on 32 bit
> systems. This problem was introduced with kernel 5.15.169.
> ```
> fs/udf/namei.c: In function 'udf_rename':
> fs/udf/namei.c:878:1: error: the frame size of 1144 bytes is larger than
> 1024 bytes [-Werror=frame-larger-than=]
>   878 | }
>       | ^
> cc1: all warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:289: fs/udf/namei.o] Error 1
> make[1]: *** [scripts/Makefile.build:552: fs/udf] Error 2
> ```
> 
> This is fixed by this upstream commit:
> commit 0aba4860b0d0216a1a300484ff536171894d49d8
> Author: Jan Kara <jack@suse.cz>
> Date:   Tue Dec 20 12:38:45 2022 +0100
> 
>     udf: Allocate name buffer in directory iterator on heap
> 
> 
> Please backport this patch to 5.15 too.
> It was already backported to kernel 6.1.

I tried to take it as-is, but it broek the build.  Can you please submit
a tested version that actually works?

thanks,

greg k-h

Re: backport "udf: Allocate name buffer in directory iterator on heap" to 5.15

[Hauke Mehrtens]

On 11/11/24 13:57, Greg KH wrote:
> On Sun, Nov 10, 2024 at 06:36:08PM +0100, Hauke Mehrtens wrote:
>> Hi,
>>
>> I am running into this compile error in 5.15.171 in OpenWrt on 32 bit
>> systems. This problem was introduced with kernel 5.15.169.
>> ```
>> fs/udf/namei.c: In function 'udf_rename':
>> fs/udf/namei.c:878:1: error: the frame size of 1144 bytes is larger than
>> 1024 bytes [-Werror=frame-larger-than=]
>>    878 | }
>>        | ^
>> cc1: all warnings being treated as errors
>> make[2]: *** [scripts/Makefile.build:289: fs/udf/namei.o] Error 1
>> make[1]: *** [scripts/Makefile.build:552: fs/udf] Error 2
>> ```
>>
>> This is fixed by this upstream commit:
>> commit 0aba4860b0d0216a1a300484ff536171894d49d8
>> Author: Jan Kara <jack@suse.cz>
>> Date:   Tue Dec 20 12:38:45 2022 +0100
>>
>>      udf: Allocate name buffer in directory iterator on heap
>>
>>
>> Please backport this patch to 5.15 too.
>> It was already backported to kernel 6.1.
> 
> I tried to take it as-is, but it broek the build.  Can you please submit
> a tested version that actually works?
> 
> thanks,
> 
> greg k-h
Hi,

I just noticed that it does no compile on x86, I only tested it on MIPS 
and there it compiles.

I already have a fixed version will send it soon.


Hauke