ocfs2 broken for me in 6.6.y since 6.6.55

ocfs2 broken for me in 6.6.y since 6.6.55

[Thomas Voegtle]

Hi,

ocfs2 on a drbd device, writing something to it, then unmount ends up in:


[ 1135.766639] OCFS2: ERROR (device drbd0): ocfs2_block_group_clear_bits:
Group descriptor # 4128768 has bit count 32256 but claims 33222 are freed.
num_bits 996
[ 1135.766645] On-disk corruption discovered. Please run fsck.ocfs2 once
the filesystem is unmounted.
[ 1135.766647] (umount,10751,3):_ocfs2_free_suballoc_bits:2490 ERROR:
status = -30
[ 1135.766650] (umount,10751,3):_ocfs2_free_clusters:2573 ERROR: status =
-30
[ 1135.766652] (umount,10751,3):ocfs2_sync_local_to_main:1027 ERROR:
status = -30
[ 1135.766654] (umount,10751,3):ocfs2_sync_local_to_main:1032 ERROR:
status = -30
[ 1135.766656] (umount,10751,3):ocfs2_shutdown_local_alloc:449 ERROR:
status = -30
[ 1135.965908] ocfs2: Unmounting device (147,0) on (node 2)


This is since 6.6.55, reverting this patch helps:

commit e7a801014726a691d4aa6e3839b3f0940ea41591
Author: Heming Zhao <heming.zhao@suse.com>
Date:   Fri Jul 19 19:43:10 2024 +0800

     ocfs2: fix the la space leak when unmounting an ocfs2 volume

     commit dfe6c5692fb525e5e90cefe306ee0dffae13d35f upstream.


Linux 6.1.119 is also broken, but 6.12.4 is fine.

I guess there is something missing?


     Thomas

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Joseph Qi]

See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t

On 2024/12/12 18:32, Thomas Voegtle wrote:
> 
> Hi,
> 
> ocfs2 on a drbd device, writing something to it, then unmount ends up in:
> 
> 
> [ 1135.766639] OCFS2: ERROR (device drbd0): ocfs2_block_group_clear_bits:
> Group descriptor # 4128768 has bit count 32256 but claims 33222 are freed.
> num_bits 996
> [ 1135.766645] On-disk corruption discovered. Please run fsck.ocfs2 once
> the filesystem is unmounted.
> [ 1135.766647] (umount,10751,3):_ocfs2_free_suballoc_bits:2490 ERROR:
> status = -30
> [ 1135.766650] (umount,10751,3):_ocfs2_free_clusters:2573 ERROR: status =
> -30
> [ 1135.766652] (umount,10751,3):ocfs2_sync_local_to_main:1027 ERROR:
> status = -30
> [ 1135.766654] (umount,10751,3):ocfs2_sync_local_to_main:1032 ERROR:
> status = -30
> [ 1135.766656] (umount,10751,3):ocfs2_shutdown_local_alloc:449 ERROR:
> status = -30
> [ 1135.965908] ocfs2: Unmounting device (147,0) on (node 2)
> 
> 
> This is since 6.6.55, reverting this patch helps:
> 
> commit e7a801014726a691d4aa6e3839b3f0940ea41591
> Author: Heming Zhao <heming.zhao@suse.com>
> Date:   Fri Jul 19 19:43:10 2024 +0800
> 
>     ocfs2: fix the la space leak when unmounting an ocfs2 volume
> 
>     commit dfe6c5692fb525e5e90cefe306ee0dffae13d35f upstream.
> 
> 
> Linux 6.1.119 is also broken, but 6.12.4 is fine.
> 
> I guess there is something missing?
> 
> 
>     Thomas

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Thomas Voegtle]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

On Thu, 12 Dec 2024, Joseph Qi wrote:

> See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t
>
> On 2024/12/12 18:32, Thomas Voegtle wrote:
>>
>> Hi,
>>
>> ocfs2 on a drbd device, writing something to it, then unmount ends up in:
>>
>>
>> [ 1135.766639] OCFS2: ERROR (device drbd0): ocfs2_block_group_clear_bits:
>> Group descriptor # 4128768 has bit count 32256 but claims 33222 are freed.
>> num_bits 996
>> [ 1135.766645] On-disk corruption discovered. Please run fsck.ocfs2 once
>> the filesystem is unmounted.
>> [ 1135.766647] (umount,10751,3):_ocfs2_free_suballoc_bits:2490 ERROR:
>> status = -30
>> [ 1135.766650] (umount,10751,3):_ocfs2_free_clusters:2573 ERROR: status =
>> -30
>> [ 1135.766652] (umount,10751,3):ocfs2_sync_local_to_main:1027 ERROR:
>> status = -30
>> [ 1135.766654] (umount,10751,3):ocfs2_sync_local_to_main:1032 ERROR:
>> status = -30
>> [ 1135.766656] (umount,10751,3):ocfs2_shutdown_local_alloc:449 ERROR:
>> status = -30
>> [ 1135.965908] ocfs2: Unmounting device (147,0) on (node 2)
>>
>>
>> This is since 6.6.55, reverting this patch helps:
>>
>> commit e7a801014726a691d4aa6e3839b3f0940ea41591
>> Author: Heming Zhao <heming.zhao@suse.com>
>> Date:   Fri Jul 19 19:43:10 2024 +0800
>>
>>     ocfs2: fix the la space leak when unmounting an ocfs2 volume
>>
>>     commit dfe6c5692fb525e5e90cefe306ee0dffae13d35f upstream.
>>
>>
>> Linux 6.1.119 is also broken, but 6.12.4 is fine.
>>
>> I guess there is something missing?
>>
>>
>>     Thomas
>
>


Ah, thanks, I didn't read that.

     Thomas

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Greg KH]

On Thu, Dec 12, 2024 at 06:41:58PM +0800, Joseph Qi wrote:
> See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t

And I need a working backport that I can apply to fix this :(

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Heming Zhao]

Hi Greg,

On 12/12/24 18:54, Greg KH wrote:
> On Thu, Dec 12, 2024 at 06:41:58PM +0800, Joseph Qi wrote:
>> See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t
> 
> And I need a working backport that I can apply to fix this :(

I submitted a v2 patch set [1], which has been passed review.

[1]:
https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#mc63e77487c4c7baba6d28fd536509e964ce3b892

-Heming

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Greg KH]

On Thu, Dec 12, 2024 at 07:01:08PM +0800, Heming Zhao wrote:
> Hi Greg,
> 
> On 12/12/24 18:54, Greg KH wrote:
> > On Thu, Dec 12, 2024 at 06:41:58PM +0800, Joseph Qi wrote:
> > > See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t
> > 
> > And I need a working backport that I can apply to fix this :(
> 
> I submitted a v2 patch set [1], which has been passed review.
> 
> [1]:
> https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#mc63e77487c4c7baba6d28fd536509e964ce3b892

Then please submit it to the stable maintainers so that we can apply it.

thanks,

greg k-h

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Joseph Qi]

On 2024/12/12 19:06, Greg KH wrote:
> On Thu, Dec 12, 2024 at 07:01:08PM +0800, Heming Zhao wrote:
>> Hi Greg,
>>
>> On 12/12/24 18:54, Greg KH wrote:
>>> On Thu, Dec 12, 2024 at 06:41:58PM +0800, Joseph Qi wrote:
>>>> See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t
>>>
>>> And I need a working backport that I can apply to fix this :(
>>
>> I submitted a v2 patch set [1], which has been passed review.
>>
>> [1]:
>> https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#mc63e77487c4c7baba6d28fd536509e964ce3b892
> 
> Then please submit it to the stable maintainers so that we can apply it.
> 

The two patches are now in mm-tree.
We may submit the revert patch to the affected stable trees once it goes into upstream.

Thanks,
Joseph

Re: ocfs2 broken for me in 6.6.y since 6.6.55

[Greg KH]

On Thu, Dec 12, 2024 at 07:15:17PM +0800, Joseph Qi wrote:
> 
> 
> On 2024/12/12 19:06, Greg KH wrote:
> > On Thu, Dec 12, 2024 at 07:01:08PM +0800, Heming Zhao wrote:
> >> Hi Greg,
> >>
> >> On 12/12/24 18:54, Greg KH wrote:
> >>> On Thu, Dec 12, 2024 at 06:41:58PM +0800, Joseph Qi wrote:
> >>>> See: https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#t
> >>>
> >>> And I need a working backport that I can apply to fix this :(
> >>
> >> I submitted a v2 patch set [1], which has been passed review.
> >>
> >> [1]:
> >> https://lore.kernel.org/ocfs2-devel/20241205104835.18223-1-heming.zhao@suse.com/T/#mc63e77487c4c7baba6d28fd536509e964ce3b892
> > 
> > Then please submit it to the stable maintainers so that we can apply it.
> > 
> 
> The two patches are now in mm-tree.
> We may submit the revert patch to the affected stable trees once it goes into upstream.

Ah, sorry, I thought this was for a stable-only series.  Nevermind, I'll
wait :)

thanks,

greg k-h