stable-rc: queues: v5.10.233: drivers/of/address.c:272:23: error: implicit declaration of function 'pci_register_io_range'

stable-rc: queues: v5.10.233: drivers/of/address.c:272:23: error: implicit declaration of function 'pci_register_io_range'

[Naresh Kamboju]

The following build warnings / errors noticed with tinyconfig builds
on stable-rc queues 5.10.

Build error:
---------
kernel/sched/fair.c:8653:13: warning: 'update_nohz_stats' defined but
not used [-Wunused-function]
 8653 | static bool update_nohz_stats(struct rq *rq)
      |             ^~~~~~~~~~~~~~~~~
drivers/of/address.c: In function 'of_pci_range_to_resource':
  272 |                 err = pci_register_io_range(&np->fwnode,
range->cpu_addr,drivers/of/address.c:272:23: error: implicit
declaration of function 'pci_register_io_range'; did you mean
'pci_register_driver'? [-Werror=implicit-function-declaration]
      |                       ^~~~~~~~~~~~~~~~~~~~~
      |                       pci_register_driver
cc1: some warnings being treated as errors

Anders bisected this and found,
# first bad commit:
  [00ec41adffcf855c3812cec7b265f43c60752f63]
  of: address: Use IS_ENABLED() for !CONFIG_PCI

arm, arm64, mips, powerpc and riscv:
  build:
   * clang-19-tinyconfig
   * clang-nightly-tinyconfig
   * gcc-12-tinyconfig
   * gcc-8-tinyconfig

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build regression:
gcc-compiler-drivers_of_address_c-error-implicit-declaration-of-function-pci_register_io_range-did-you-mean-pci_register_driver

metadata:
----
  build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.10/build/v5.10.233-115-gdf787b08d487/testrun/26848040/suite/build/test/gcc-12-tinyconfig/log
  config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2rwDemGhjGUiyKwSFMekoPRvmIv/config
  kernel tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
  git describe: v5.10.233-115-gdf787b08d487
  architectures: arm, arm64, mips, powerpc, riscv
  history: https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.10/build/v5.10.233-115-gdf787b08d487/testrun/26847981/suite/build/test/gcc-12-tinyconfig/history/

steps to reproduce:
--------
- tuxmake --runtime podman --target-arch arm64 --toolchain gcc-12
--kconfig tinyconfig

--
Linaro LKFT
https://lkft.linaro.org

Re: stable-rc: queues: v5.10.233: drivers/of/address.c:272:23: error: implicit declaration of function 'pci_register_io_range'

[Greg Kroah-Hartman]

On Tue, Jan 21, 2025 at 09:05:25PM +0530, Naresh Kamboju wrote:
> The following build warnings / errors noticed with tinyconfig builds
> on stable-rc queues 5.10.
> 
> Build error:
> ---------
> kernel/sched/fair.c:8653:13: warning: 'update_nohz_stats' defined but
> not used [-Wunused-function]
>  8653 | static bool update_nohz_stats(struct rq *rq)
>       |             ^~~~~~~~~~~~~~~~~
> drivers/of/address.c: In function 'of_pci_range_to_resource':
>   272 |                 err = pci_register_io_range(&np->fwnode,
> range->cpu_addr,drivers/of/address.c:272:23: error: implicit
> declaration of function 'pci_register_io_range'; did you mean
> 'pci_register_driver'? [-Werror=implicit-function-declaration]
>       |                       ^~~~~~~~~~~~~~~~~~~~~
>       |                       pci_register_driver
> cc1: some warnings being treated as errors
> 
> Anders bisected this and found,
> # first bad commit:
>   [00ec41adffcf855c3812cec7b265f43c60752f63]
>   of: address: Use IS_ENABLED() for !CONFIG_PCI

Thanks, I think I've fixed this up now.

greg k-h