public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: gregkh@linuxfoundation.org
Cc: GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@hansenpartnership.com, arun.easi@cavium.com,
	bvanassche@acm.org, jhasan@marvell.com,
	jiashengjiangcool@gmail.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, manish.rangankar@cavium.com,
	markus.elfring@web.de, martin.petersen@oracle.com,
	nilesh.javali@cavium.com, skashyap@marvell.com,
	stable@vger.kernel.org
Subject: [PATCH v3 2/2] scsi: qedf: Add check for bdt_info
Date: Fri,  7 Feb 2025 15:45:05 +0000	[thread overview]
Message-ID: <20250207154505.4819-2-jiashengjiangcool@gmail.com> (raw)
In-Reply-To: <20250207154505.4819-1-jiashengjiangcool@gmail.com>

Add a check for "bdt_info". Otherwise, if one of the allocations
for "cmgr->io_bdt_pool[i]" fails, "bdt_info->bd_tbl" will cause a NULL
pointer dereference.

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Cc: <stable@vger.kernel.org> # v5.10+
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:

v2 -> v3:

1. No change.

v1 -> v2:

1. No change.
---
 drivers/scsi/qedf/qedf_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index d52057b97a4f..1ed0ee4f8dde 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -125,7 +125,7 @@ void qedf_cmd_mgr_free(struct qedf_cmd_mgr *cmgr)
 	bd_tbl_sz = QEDF_MAX_BDS_PER_CMD * sizeof(struct scsi_sge);
 	for (i = 0; i < num_ios; i++) {
 		bdt_info = cmgr->io_bdt_pool[i];
-		if (bdt_info->bd_tbl) {
+		if (bdt_info && bdt_info->bd_tbl) {
 			dma_free_coherent(&qedf->pdev->dev, bd_tbl_sz,
 			    bdt_info->bd_tbl, bdt_info->bd_tbl_dma);
 			bdt_info->bd_tbl = NULL;
-- 
2.25.1


  reply	other threads:[~2025-02-07 15:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <d4db5506-6ace-4585-972e-6b7a6fc882a4@web.de>
     [not found] ` <20250206052523.16683-1-jiashengjiangcool@gmail.com>
2025-02-06  5:25   ` [PATCH 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-06  5:36     ` Greg KH
2025-02-06  5:38       ` Greg KH
2025-02-06 19:19         ` [PATCH v2 " Jiasheng Jiang
2025-02-06 19:20           ` [PATCH v2 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-07 15:09           ` [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Greg KH
2025-02-07 15:45             ` [PATCH v3 " Jiasheng Jiang
2025-02-07 15:45               ` Jiasheng Jiang [this message]
2025-02-07 15:46             ` [PATCH v2 " Jiasheng Jiang
2025-02-06  5:25   ` [PATCH 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
     [not found] <444d6d33-d916-467b-aea8-25c61977713a@web.de>
     [not found] ` <20250205010732.16891-1-jiashengjiangcool@gmail.com>
2025-02-05  1:07   ` [PATCH v3 " Jiasheng Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207154505.4819-2-jiashengjiangcool@gmail.com \
    --to=jiashengjiangcool@gmail.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=arun.easi@cavium.com \
    --cc=bvanassche@acm.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhasan@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manish.rangankar@cavium.com \
    --cc=markus.elfring@web.de \
    --cc=martin.petersen@oracle.com \
    --cc=nilesh.javali@cavium.com \
    --cc=skashyap@marvell.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox