From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com,
James.Bottomley@hansenpartnership.com, arun.easi@cavium.com,
bvanassche@acm.org, jhasan@marvell.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
manish.rangankar@cavium.com, markus.elfring@web.de,
martin.petersen@oracle.com, nilesh.javali@cavium.com,
skashyap@marvell.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc()
Date: Fri, 7 Feb 2025 16:09:58 +0100 [thread overview]
Message-ID: <2025020721-silver-uneasy-5565@gregkh> (raw)
In-Reply-To: <20250206192000.17827-1-jiashengjiangcool@gmail.com>
On Thu, Feb 06, 2025 at 07:19:59PM +0000, Jiasheng Jiang wrote:
> Replace kmalloc_array() with kcalloc() to avoid old (dirty) data being
> used/freed.
"Potentially" being freed. It will not be used. And this is only for
an error path that obviously no one has hit before.
Please explain this much better.
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-07 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d4db5506-6ace-4585-972e-6b7a6fc882a4@web.de>
[not found] ` <20250206052523.16683-1-jiashengjiangcool@gmail.com>
2025-02-06 5:25 ` [PATCH 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-06 5:36 ` Greg KH
2025-02-06 5:38 ` Greg KH
2025-02-06 19:19 ` [PATCH v2 " Jiasheng Jiang
2025-02-06 19:20 ` [PATCH v2 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-07 15:09 ` Greg KH [this message]
2025-02-07 15:45 ` [PATCH v3 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-07 15:45 ` [PATCH v3 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-07 15:46 ` [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-06 5:25 ` [PATCH 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025020721-silver-uneasy-5565@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arun.easi@cavium.com \
--cc=bvanassche@acm.org \
--cc=jhasan@marvell.com \
--cc=jiashengjiangcool@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manish.rangankar@cavium.com \
--cc=markus.elfring@web.de \
--cc=martin.petersen@oracle.com \
--cc=nilesh.javali@cavium.com \
--cc=skashyap@marvell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox