* [PATCH RESEND] drm/tegra: fix a possible null pointer dereference
@ 2025-02-12 1:42 Qiu-ji Chen
2025-05-07 16:08 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Qiu-ji Chen @ 2025-02-12 1:42 UTC (permalink / raw)
To: thierry.reding, mperttunen, airlied, simona, jonathanh
Cc: dri-devel, linux-tegra, linux-kernel, baijiaju1990, Qiu-ji Chen,
stable
In tegra_crtc_reset(), new memory is allocated with kzalloc(), but
no check is performed. Before calling __drm_atomic_helper_crtc_reset,
state should be checked to prevent possible null pointer dereference.
Fixes: b7e0b04ae450 ("drm/tegra: Convert to using __drm_atomic_helper_crtc_reset() for reset.")
Cc: stable@vger.kernel.org
Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
---
drivers/gpu/drm/tegra/dc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index be61c9d1a4f0..1ed30853bd9e 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1388,7 +1388,10 @@ static void tegra_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
tegra_crtc_atomic_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &state->base);
+ if (state)
+ __drm_atomic_helper_crtc_reset(crtc, &state->base);
+ else
+ __drm_atomic_helper_crtc_reset(crtc, NULL);
}
static struct drm_crtc_state *
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] drm/tegra: fix a possible null pointer dereference
2025-02-12 1:42 [PATCH RESEND] drm/tegra: fix a possible null pointer dereference Qiu-ji Chen
@ 2025-05-07 16:08 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2025-05-07 16:08 UTC (permalink / raw)
To: Qiu-ji Chen
Cc: mperttunen, airlied, simona, jonathanh, dri-devel, linux-tegra,
linux-kernel, baijiaju1990, stable
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Wed, Feb 12, 2025 at 09:42:45AM +0800, Qiu-ji Chen wrote:
> In tegra_crtc_reset(), new memory is allocated with kzalloc(), but
> no check is performed. Before calling __drm_atomic_helper_crtc_reset,
> state should be checked to prevent possible null pointer dereference.
>
> Fixes: b7e0b04ae450 ("drm/tegra: Convert to using __drm_atomic_helper_crtc_reset() for reset.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
> ---
> drivers/gpu/drm/tegra/dc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-07 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-12 1:42 [PATCH RESEND] drm/tegra: fix a possible null pointer dereference Qiu-ji Chen
2025-05-07 16:08 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox