* [PATCH] iio: adis16201: Correct inclinometer channel resolution [not found] <20250421124915.32a18d36@jic23-huawei> @ 2025-04-21 13:15 ` Gabriel Shahrouzi 2025-04-21 13:50 ` Marcelo Schmitt 2025-04-21 13:59 ` Jonathan Cameron 0 siblings, 2 replies; 8+ messages in thread From: Gabriel Shahrouzi @ 2025-04-21 13:15 UTC (permalink / raw) To: jic23 Cc: lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, marcelo.schmitt1, Gabriel Shahrouzi, stable The inclinometer channels were previously defined with 14 realbits. However, the ADIS16201 datasheet states the resolution for these output channels is 12 bits (Page 14, text description; Page 15, table 7). Correct the realbits value to 12 to accurately reflect the hardware. Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") Cc: stable@vger.kernel.org Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> --- drivers/iio/accel/adis16201.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c index 982b33f6eccac..dcc8d9f2ee0f1 100644 --- a/drivers/iio/accel/adis16201.c +++ b/drivers/iio/accel/adis16201.c @@ -211,9 +211,9 @@ static const struct iio_chan_spec adis16201_channels[] = { BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12), ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X, - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y, - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), IIO_CHAN_SOFT_TIMESTAMP(7) }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:15 ` [PATCH] iio: adis16201: Correct inclinometer channel resolution Gabriel Shahrouzi @ 2025-04-21 13:50 ` Marcelo Schmitt 2025-04-21 13:55 ` Gabriel Shahrouzi 2025-04-21 13:59 ` Jonathan Cameron 1 sibling, 1 reply; 8+ messages in thread From: Marcelo Schmitt @ 2025-04-21 13:50 UTC (permalink / raw) To: Gabriel Shahrouzi Cc: jic23, lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, stable On 04/21, Gabriel Shahrouzi wrote: > The inclinometer channels were previously defined with 14 realbits. > However, the ADIS16201 datasheet states the resolution for these output > channels is 12 bits (Page 14, text description; Page 15, table 7). > > Correct the realbits value to 12 to accurately reflect the hardware. > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > Cc: stable@vger.kernel.org > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:50 ` Marcelo Schmitt @ 2025-04-21 13:55 ` Gabriel Shahrouzi 2025-04-21 14:08 ` Marcelo Schmitt 2025-04-21 14:10 ` Jonathan Cameron 0 siblings, 2 replies; 8+ messages in thread From: Gabriel Shahrouzi @ 2025-04-21 13:55 UTC (permalink / raw) To: Marcelo Schmitt Cc: jic23, lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, stable On Mon, Apr 21, 2025 at 9:48 AM Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote: > > On 04/21, Gabriel Shahrouzi wrote: > > The inclinometer channels were previously defined with 14 realbits. > > However, the ADIS16201 datasheet states the resolution for these output > > channels is 12 bits (Page 14, text description; Page 15, table 7). > > > > Correct the realbits value to 12 to accurately reflect the hardware. > > > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> Should I have included the reviewed-by tag on the latest patch sent in this thread since there were no changes to the code? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:55 ` Gabriel Shahrouzi @ 2025-04-21 14:08 ` Marcelo Schmitt 2025-04-21 14:16 ` Gabriel Shahrouzi 2025-04-21 14:10 ` Jonathan Cameron 1 sibling, 1 reply; 8+ messages in thread From: Marcelo Schmitt @ 2025-04-21 14:08 UTC (permalink / raw) To: Gabriel Shahrouzi Cc: jic23, lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, stable On 04/21, Gabriel Shahrouzi wrote: > On Mon, Apr 21, 2025 at 9:48 AM Marcelo Schmitt > <marcelo.schmitt1@gmail.com> wrote: > > > > On 04/21, Gabriel Shahrouzi wrote: > > > The inclinometer channels were previously defined with 14 realbits. > > > However, the ADIS16201 datasheet states the resolution for these output > > > channels is 12 bits (Page 14, text description; Page 15, table 7). > > > > > > Correct the realbits value to 12 to accurately reflect the hardware. > > > > > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> > > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > Should I have included the reviewed-by tag on the latest patch sent in > this thread since there were no changes to the code? Not sure I had given a review tag for this. Hard to find the previous versrion because it doesn't seem to contain adis16201 in the subject name :/ Anyway, good thing the fix should be added to IIO now. Regards, Marcelo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 14:08 ` Marcelo Schmitt @ 2025-04-21 14:16 ` Gabriel Shahrouzi 0 siblings, 0 replies; 8+ messages in thread From: Gabriel Shahrouzi @ 2025-04-21 14:16 UTC (permalink / raw) To: Marcelo Schmitt Cc: jic23, lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, stable On Mon, Apr 21, 2025 at 10:06 AM Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote: > > On 04/21, Gabriel Shahrouzi wrote: > > On Mon, Apr 21, 2025 at 9:48 AM Marcelo Schmitt > > <marcelo.schmitt1@gmail.com> wrote: > > > > > > On 04/21, Gabriel Shahrouzi wrote: > > > > The inclinometer channels were previously defined with 14 realbits. > > > > However, the ADIS16201 datasheet states the resolution for these output > > > > channels is 12 bits (Page 14, text description; Page 15, table 7). > > > > > > > > Correct the realbits value to 12 to accurately reflect the hardware. > > > > > > > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> > > > > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > Should I have included the reviewed-by tag on the latest patch sent in > > this thread since there were no changes to the code? > > Not sure I had given a review tag for this. Ah it's probably because I resent the patch in the same thread. > Hard to find the previous versrion because it doesn't seem to contain adis16201 > in the subject name :/ > Anyway, good thing the fix should be added to IIO now. > > Regards, > Marcelo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:55 ` Gabriel Shahrouzi 2025-04-21 14:08 ` Marcelo Schmitt @ 2025-04-21 14:10 ` Jonathan Cameron 1 sibling, 0 replies; 8+ messages in thread From: Jonathan Cameron @ 2025-04-21 14:10 UTC (permalink / raw) To: Gabriel Shahrouzi Cc: Marcelo Schmitt, lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, stable On Mon, 21 Apr 2025 09:55:24 -0400 Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > On Mon, Apr 21, 2025 at 9:48 AM Marcelo Schmitt > <marcelo.schmitt1@gmail.com> wrote: > > > > On 04/21, Gabriel Shahrouzi wrote: > > > The inclinometer channels were previously defined with 14 realbits. > > > However, the ADIS16201 datasheet states the resolution for these output > > > channels is 12 bits (Page 14, text description; Page 15, table 7). > > > > > > Correct the realbits value to 12 to accurately reflect the hardware. > > > > > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> > > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > Should I have included the reviewed-by tag on the latest patch sent in > this thread since there were no changes to the code? > Yes, but that was all a mix up anyway so don't worry about it. I have the tag anyway. Jonathan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:15 ` [PATCH] iio: adis16201: Correct inclinometer channel resolution Gabriel Shahrouzi 2025-04-21 13:50 ` Marcelo Schmitt @ 2025-04-21 13:59 ` Jonathan Cameron 2025-04-21 14:20 ` Gabriel Shahrouzi 1 sibling, 1 reply; 8+ messages in thread From: Jonathan Cameron @ 2025-04-21 13:59 UTC (permalink / raw) To: Gabriel Shahrouzi Cc: lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, marcelo.schmitt1, stable On Mon, 21 Apr 2025 09:15:39 -0400 Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > The inclinometer channels were previously defined with 14 realbits. > However, the ADIS16201 datasheet states the resolution for these output > channels is 12 bits (Page 14, text description; Page 15, table 7). > > Correct the realbits value to 12 to accurately reflect the hardware. > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > Cc: stable@vger.kernel.org > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> If you post a new version, always add the version number. Anyhow, I was just asking for the fixes tag, but this is fine. Applied to the fixes-togreg branch of iio.git Thanks, Jonathan > --- > drivers/iio/accel/adis16201.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c > index 982b33f6eccac..dcc8d9f2ee0f1 100644 > --- a/drivers/iio/accel/adis16201.c > +++ b/drivers/iio/accel/adis16201.c > @@ -211,9 +211,9 @@ static const struct iio_chan_spec adis16201_channels[] = { > BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12), > ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X, > - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), > ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y, > - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), > IIO_CHAN_SOFT_TIMESTAMP(7) > }; > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution 2025-04-21 13:59 ` Jonathan Cameron @ 2025-04-21 14:20 ` Gabriel Shahrouzi 0 siblings, 0 replies; 8+ messages in thread From: Gabriel Shahrouzi @ 2025-04-21 14:20 UTC (permalink / raw) To: Jonathan Cameron Cc: lars, linux-iio, linux-kernel, Michael.Hennerich, skhan, linux-kernel-mentees, marcelo.schmitt1, stable On Mon, Apr 21, 2025 at 9:59 AM Jonathan Cameron <jic23@kernel.org> wrote: > > On Mon, 21 Apr 2025 09:15:39 -0400 > Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote: > > > The inclinometer channels were previously defined with 14 realbits. > > However, the ADIS16201 datasheet states the resolution for these output > > channels is 12 bits (Page 14, text description; Page 15, table 7). > > > > Correct the realbits value to 12 to accurately reflect the hardware. > > > > Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> > If you post a new version, always add the version number. > > Anyhow, I was just asking for the fixes tag, but this is fine. Ah, that makes sense - thanks for the clarification. I was debating whether to just send the Fixes tag or resend the full patch, and figured the full patch might make it easier to apply. > > Applied to the fixes-togreg branch of iio.git > > Thanks, > > Jonathan > > > --- > > drivers/iio/accel/adis16201.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c > > index 982b33f6eccac..dcc8d9f2ee0f1 100644 > > --- a/drivers/iio/accel/adis16201.c > > +++ b/drivers/iio/accel/adis16201.c > > @@ -211,9 +211,9 @@ static const struct iio_chan_spec adis16201_channels[] = { > > BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > > ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12), > > ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X, > > - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > > + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), > > ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y, > > - BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), > > + BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12), > > IIO_CHAN_SOFT_TIMESTAMP(7) > > }; > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-04-21 14:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250421124915.32a18d36@jic23-huawei>
2025-04-21 13:15 ` [PATCH] iio: adis16201: Correct inclinometer channel resolution Gabriel Shahrouzi
2025-04-21 13:50 ` Marcelo Schmitt
2025-04-21 13:55 ` Gabriel Shahrouzi
2025-04-21 14:08 ` Marcelo Schmitt
2025-04-21 14:16 ` Gabriel Shahrouzi
2025-04-21 14:10 ` Jonathan Cameron
2025-04-21 13:59 ` Jonathan Cameron
2025-04-21 14:20 ` Gabriel Shahrouzi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox