* + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
@ 2025-07-21 21:13 Andrew Morton
2025-07-23 15:29 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2025-07-21 21:13 UTC (permalink / raw)
To: mm-commits, stable, senozhatsky, rostedt, pmladek, linux, herbert,
andriy.shevchenko, sfr, akpm
The patch titled
Subject: sprintf.h requires stdarg.h
has been added to the -mm mm-hotfixes-unstable branch. Its filename is
sprintfh-requires-stdargh.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/sprintfh-requires-stdargh.patch
This patch will later appear in the mm-hotfixes-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: sprintf.h requires stdarg.h
Date: Mon, 21 Jul 2025 16:15:57 +1000
In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
| ^~~~~~~
include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
Link: https://lkml.kernel.org/r/20250721173754.42865913@canb.auug.org.au
Fixes: 39ced19b9e60 ("lib/vsprintf: split out sprintf() and friends")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andriy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/sprintf.h | 1 +
1 file changed, 1 insertion(+)
--- a/include/linux/sprintf.h~sprintfh-requires-stdargh
+++ a/include/linux/sprintf.h
@@ -4,6 +4,7 @@
#include <linux/compiler_attributes.h>
#include <linux/types.h>
+#include <linux/stdarg.h>
int num_to_str(char *buf, int size, unsigned long long num, unsigned int width);
_
Patches currently in -mm which might be from sfr@canb.auug.org.au are
sprintfh-requires-stdargh.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
2025-07-21 21:13 + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch Andrew Morton
@ 2025-07-23 15:29 ` Andy Shevchenko
2025-07-23 22:39 ` Andrew Morton
2025-07-23 22:40 ` Stephen Rothwell
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-07-23 15:29 UTC (permalink / raw)
To: Andrew Morton
Cc: mm-commits, stable, senozhatsky, rostedt, pmladek, linux, herbert,
sfr
On Mon, Jul 21, 2025 at 02:13:52PM -0700, Andrew Morton wrote:
> ------------------------------------------------------
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Subject: sprintf.h requires stdarg.h
> Date: Mon, 21 Jul 2025 16:15:57 +1000
>
> In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
> include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
> 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> | ^~~~~~~
> include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
...
> #include <linux/compiler_attributes.h>
> #include <linux/types.h>
> +#include <linux/stdarg.h>
Can we prevent the ordering?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
2025-07-23 15:29 ` Andy Shevchenko
@ 2025-07-23 22:39 ` Andrew Morton
2025-07-23 22:40 ` Stephen Rothwell
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2025-07-23 22:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: mm-commits, stable, senozhatsky, rostedt, pmladek, linux, herbert,
sfr
On Wed, 23 Jul 2025 18:29:34 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Jul 21, 2025 at 02:13:52PM -0700, Andrew Morton wrote:
>
> > ------------------------------------------------------
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Subject: sprintf.h requires stdarg.h
> > Date: Mon, 21 Jul 2025 16:15:57 +1000
> >
> > In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
> > include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
> > 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> > | ^~~~~~~
> > include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
>
> ...
>
> > #include <linux/compiler_attributes.h>
> > #include <linux/types.h>
> > +#include <linux/stdarg.h>
>
> Can we prevent the ordering?
>
What do you mean?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
2025-07-23 15:29 ` Andy Shevchenko
2025-07-23 22:39 ` Andrew Morton
@ 2025-07-23 22:40 ` Stephen Rothwell
2025-07-24 11:42 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2025-07-23 22:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andrew Morton, mm-commits, stable, senozhatsky, rostedt, pmladek,
linux, herbert
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
Hi Andy,
On Wed, 23 Jul 2025 18:29:34 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Jul 21, 2025 at 02:13:52PM -0700, Andrew Morton wrote:
>
> > ------------------------------------------------------
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Subject: sprintf.h requires stdarg.h
> > Date: Mon, 21 Jul 2025 16:15:57 +1000
> >
> > In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
> > include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
> > 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> > | ^~~~~~~
> > include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
>
> ...
>
> > #include <linux/compiler_attributes.h>
> > #include <linux/types.h>
> > +#include <linux/stdarg.h>
>
> Can we prevent the ordering?
I am not sure what you mean by this. Do you want alphabetical, reverse
christmas tree, or something else? Or are you concerned with something
completely different?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
2025-07-23 22:40 ` Stephen Rothwell
@ 2025-07-24 11:42 ` Andy Shevchenko
2025-07-24 13:46 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2025-07-24 11:42 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, mm-commits, stable, senozhatsky, rostedt, pmladek,
linux, herbert
On Thu, Jul 24, 2025 at 08:40:12AM +1000, Stephen Rothwell wrote:
> On Wed, 23 Jul 2025 18:29:34 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Jul 21, 2025 at 02:13:52PM -0700, Andrew Morton wrote:
> >
> > > ------------------------------------------------------
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Subject: sprintf.h requires stdarg.h
> > > Date: Mon, 21 Jul 2025 16:15:57 +1000
> > >
> > > In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
> > > include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
> > > 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> > > | ^~~~~~~
> > > include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
...
> > > #include <linux/compiler_attributes.h>
> > > #include <linux/types.h>
> > > +#include <linux/stdarg.h>
> >
> > Can we prevent the ordering?
>
> I am not sure what you mean by this. Do you want alphabetical, reverse
> christmas tree, or something else? Or are you concerned with something
> completely different?
Alphabetical
#include <linux/compiler_attributes.h>
#include <linux/stdarg.h>
#include <linux/types.h>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
2025-07-24 11:42 ` Andy Shevchenko
@ 2025-07-24 13:46 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2025-07-24 13:46 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andrew Morton, mm-commits, stable, senozhatsky, rostedt, pmladek,
linux, herbert
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Hi Andy,
On Thu, 24 Jul 2025 14:42:18 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > > > #include <linux/compiler_attributes.h>
> > > > #include <linux/types.h>
> > > > +#include <linux/stdarg.h>
> > >
> > > Can we prevent the ordering?
> >
> > I am not sure what you mean by this. Do you want alphabetical, reverse
> > christmas tree, or something else? Or are you concerned with something
> > completely different?
>
> Alphabetical
>
> #include <linux/compiler_attributes.h>
> #include <linux/stdarg.h>
> #include <linux/types.h>
I have no strong opinion, so fine by me.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-24 13:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 21:13 + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch Andrew Morton
2025-07-23 15:29 ` Andy Shevchenko
2025-07-23 22:39 ` Andrew Morton
2025-07-23 22:40 ` Stephen Rothwell
2025-07-24 11:42 ` Andy Shevchenko
2025-07-24 13:46 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox