Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Ilya K]

On 2025-08-12 16:32, Rafael J. Wysocki wrote:
> 
> Applied as 6.17-rc material and sorry for the delay (I was offline).
> 
> Thanks!

Thanks!

Tagging stable@ so we're hopefully in time for 6.16.1.

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Greg KH]

On Tue, Aug 12, 2025 at 06:51:10PM +0300, Ilya K wrote:
> On 2025-08-12 16:32, Rafael J. Wysocki wrote:
> > 
> > Applied as 6.17-rc material and sorry for the delay (I was offline).
> > 
> > Thanks!
> 
> Thanks!
> 
> Tagging stable@ so we're hopefully in time for 6.16.1.

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Armin Wolf]

Am 12.08.25 um 18:40 schrieb Greg KH:

> On Tue, Aug 12, 2025 at 06:51:10PM +0300, Ilya K wrote:
>> On 2025-08-12 16:32, Rafael J. Wysocki wrote:
>>> Applied as 6.17-rc material and sorry for the delay (I was offline).
>>>
>>> Thanks!
>> Thanks!
>>
>> Tagging stable@ so we're hopefully in time for 6.16.1.
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Agree.

AFAIK the Fixes: tag should be enough to ensure that this patch gets included
in the affected stable kernels.

Thanks,
Armin Wolf
  

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Greg KH]

On Tue, Aug 12, 2025 at 06:54:39PM +0200, Armin Wolf wrote:
> Am 12.08.25 um 18:40 schrieb Greg KH:
> 
> > On Tue, Aug 12, 2025 at 06:51:10PM +0300, Ilya K wrote:
> > > On 2025-08-12 16:32, Rafael J. Wysocki wrote:
> > > > Applied as 6.17-rc material and sorry for the delay (I was offline).
> > > > 
> > > > Thanks!
> > > Thanks!
> > > 
> > > Tagging stable@ so we're hopefully in time for 6.16.1.
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> > 
> > </formletter>
> 
> Agree.
> 
> AFAIK the Fixes: tag should be enough to ensure that this patch gets included
> in the affected stable kernels.

Not at all!

Please read the above link for the full details on how to do this (hint,
Fixes: will not do it.)

thanks,

greg k-h

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Ilya K]

On 2025-08-12 20:10, Greg KH wrote:
> 
> Please read the above link for the full details on how to do this (hint,
> Fixes: will not do it.)
> 

I might be missing something, but doesn't that just tell you to CC stable@?
Or do you have to specifically have the CC on the initial patch submission, not anywhere in the thread?

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Rafael J. Wysocki]

On Tue, Aug 12, 2025 at 7:57 PM Ilya K <me@0upti.me> wrote:
>
> On 2025-08-12 20:10, Greg KH wrote:
> >
> > Please read the above link for the full details on how to do this (hint,
> > Fixes: will not do it.)
> >
>
> I might be missing something, but doesn't that just tell you to CC stable@?
> Or do you have to specifically have the CC on the initial patch submission, not anywhere in the thread?

A Cc: stable in a patch (or elsewhere in the thread following it) is
just a hint for the maintainer anyway.

But no worries, I've added Cc: stable to the commit.

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Greg KH]

On Tue, Aug 12, 2025 at 08:56:55PM +0300, Ilya K wrote:
> On 2025-08-12 20:10, Greg KH wrote:
> > 
> > Please read the above link for the full details on how to do this (hint,
> > Fixes: will not do it.)
> > 
> 
> I might be missing something, but doesn't that just tell you to CC stable@?

It must be in the patch itself, in the signed-off-by area.

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Rafael J. Wysocki]

On Tue, Aug 12, 2025 at 9:33 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Aug 12, 2025 at 08:56:55PM +0300, Ilya K wrote:
> > On 2025-08-12 20:10, Greg KH wrote:
> > >
> > > Please read the above link for the full details on how to do this (hint,
> > > Fixes: will not do it.)
> > >
> >
> > I might be missing something, but doesn't that just tell you to CC stable@?
>
> It must be in the patch itself, in the signed-off-by area.

Well, to be precise, it must be present in the mainline commit of that
patch and whether or not it will be there is entirely up to the
committer.

So adding a Cc: stable tag to a patch is a hint, which usually is
appreciated as long as it is accurate, but the committer may still
decide to not include it in the commit.

Re: [PATCH] ACPI: EC: Relax sanity check of the ECDT ID string

[Armin Wolf]

Am 12.08.25 um 19:10 schrieb Greg KH:

> On Tue, Aug 12, 2025 at 06:54:39PM +0200, Armin Wolf wrote:
>> Am 12.08.25 um 18:40 schrieb Greg KH:
>>
>>> On Tue, Aug 12, 2025 at 06:51:10PM +0300, Ilya K wrote:
>>>> On 2025-08-12 16:32, Rafael J. Wysocki wrote:
>>>>> Applied as 6.17-rc material and sorry for the delay (I was offline).
>>>>>
>>>>> Thanks!
>>>> Thanks!
>>>>
>>>> Tagging stable@ so we're hopefully in time for 6.16.1.
>>> <formletter>
>>>
>>> This is not the correct way to submit patches for inclusion in the
>>> stable kernel tree.  Please read:
>>>       https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>> for how to do this properly.
>>>
>>> </formletter>
>> Agree.
>>
>> AFAIK the Fixes: tag should be enough to ensure that this patch gets included
>> in the affected stable kernels.
> Not at all!
>
> Please read the above link for the full details on how to do this (hint,
> Fixes: will not do it.)
>
> thanks,
>
> greg k-h

Oops, seems that i missed something rather significant about the stable kernels.
I will give keep that in mind when sending future patches.

Thanks,
Armin Wolf