Re: [PATCH 6.6 1/2] Revert "spi: cadence-quadspi: fix cleanup of rx_chan on failure paths"

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Sep 03, 2025 at 03:58:14PM +0800, jinfeng.wang.cn@windriver.com wrote:
> From: Jinfeng Wang <jinfeng.wang.cn@windriver.com>
> 
> This reverts commit 1af6d1696ca40b2d22889b4b8bbea616f94aaa84.

What is the upstream commit id for this?

> There is cadence-qspi ff8d2000.spi: Unbalanced pm_runtime_enable! error
> without this revert.
> 
> After reverting commit cdfb20e4b34a ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
> and commit 1af6d1696ca4 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths"),
> Unbalanced pm_runtime_enable! error does not appear.
> 
> These two commits are backported from upstream commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
> and commit 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths").
> 
> The commit 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths")
> fix commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance").
> 
> The commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance") fix
> commit 86401132d7bb ("spi: spi-cadence-quadspi: Fix missing unwind goto warnings").
> 
> The commit 86401132d7bb ("spi: spi-cadence-quadspi: Fix missing unwind goto warnings") fix
> commit 0578a6dbfe75 ("spi: spi-cadence-quadspi: add runtime pm support").

I am sorry, but I can not parse any of this.

> 6.6.y only backport commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
> and commit 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths"),
> but does not backport commit 0578a6dbfe75 ("spi: spi-cadence-quadspi: add runtime pm support")
> and commit 86401132d7bb ("spi: spi-cadence-quadspi: Fix missing unwind goto warnings").
> And the backport of commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
> differs with the original patch. So there is Unbalanced pm_runtime_enable error.
> 
> If revert the backport for commit b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
> and commit 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths"), there is no error.
> If backport commit 0578a6dbfe75 ("spi: spi-cadence-quadspi: add runtime pm support") and
> commit 86401132d7bb ("spi: spi-cadence-quadspi: Fix missing unwind goto warnings"), there
> is hang during booting. I didn't find the cause of the hang.

Is this hang also in newer kernels?  Why is this only an issue in older
kernels?

thanks,

greg k-h