* [PATCH] media: staging/ipu7: fix isys device runtime PM usage in firmware closing
@ 2025-09-09 3:21 bingbu.cao
2025-09-09 5:20 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: bingbu.cao @ 2025-09-09 3:21 UTC (permalink / raw)
To: linux-media, sakari.ailus, laurent.pinchart
Cc: tomi.valkeinen, hans, stable, bingbu.cao, bingbu.cao
From: Bingbu Cao <bingbu.cao@intel.com>
The PM usage counter of isys was bumped up when start camera stream
(opening firmware) but it was not dropped after stream stop(closing
firmware), it forbids system fail to suspend due to the wrong PM state
of ISYS. This patch drop the PM usage counter in firmware close to fix
it.
Cc: Stable@vger.kernel.org
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
drivers/staging/media/ipu7/ipu7-isys-video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/ipu7/ipu7-isys-video.c b/drivers/staging/media/ipu7/ipu7-isys-video.c
index 8756da3a8fb0..173afd405d9b 100644
--- a/drivers/staging/media/ipu7/ipu7-isys-video.c
+++ b/drivers/staging/media/ipu7/ipu7-isys-video.c
@@ -946,6 +946,7 @@ void ipu7_isys_fw_close(struct ipu7_isys *isys)
ipu7_fw_isys_close(isys);
mutex_unlock(&isys->mutex);
+ pm_runtime_put(&isys->adev->auxdev.dev);
}
int ipu7_isys_setup_video(struct ipu7_isys_video *av,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: staging/ipu7: fix isys device runtime PM usage in firmware closing
2025-09-09 3:21 [PATCH] media: staging/ipu7: fix isys device runtime PM usage in firmware closing bingbu.cao
@ 2025-09-09 5:20 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2025-09-09 5:20 UTC (permalink / raw)
To: bingbu.cao
Cc: linux-media, laurent.pinchart, tomi.valkeinen, hans, stable,
bingbu.cao
Hi Bingbu,
On Tue, Sep 09, 2025 at 11:21:48AM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> The PM usage counter of isys was bumped up when start camera stream
> (opening firmware) but it was not dropped after stream stop(closing
> firmware), it forbids system fail to suspend due to the wrong PM state
> of ISYS. This patch drop the PM usage counter in firmware close to fix
> it.
>
> Cc: Stable@vger.kernel.org
Can you provide a Fixes: tag, too?
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> ---
> drivers/staging/media/ipu7/ipu7-isys-video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/ipu7/ipu7-isys-video.c b/drivers/staging/media/ipu7/ipu7-isys-video.c
> index 8756da3a8fb0..173afd405d9b 100644
> --- a/drivers/staging/media/ipu7/ipu7-isys-video.c
> +++ b/drivers/staging/media/ipu7/ipu7-isys-video.c
> @@ -946,6 +946,7 @@ void ipu7_isys_fw_close(struct ipu7_isys *isys)
> ipu7_fw_isys_close(isys);
>
> mutex_unlock(&isys->mutex);
> + pm_runtime_put(&isys->adev->auxdev.dev);
> }
>
> int ipu7_isys_setup_video(struct ipu7_isys_video *av,
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-09 5:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 3:21 [PATCH] media: staging/ipu7: fix isys device runtime PM usage in firmware closing bingbu.cao
2025-09-09 5:20 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox