From: Ravi Kumar Bandi <ravib@amazon.com>
To: <mani@kernel.org>, <thippeswamy.havalige@amd.com>
Cc: <lpieralisi@kernel.org>, <bhelgaas@google.com>,
<linux-pci@vger.kernel.org>, <kwilczynski@kernel.org>,
<robh@kernel.org>, <ravib@amazon.com>, <michal.simek@amd.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts
Date: Sat, 20 Sep 2025 22:52:32 +0000 [thread overview]
Message-ID: <20250920225232.18757-1-ravib@amazon.com> (raw)
In-Reply-To: <C47CF283-C0C4-4ACF-BE07-3E87153D6EC6@amazon.com>
The pcie-xilinx-dma-pl driver does not enable INTx interrupts
after initializing the port, preventing INTx interrupts from
PCIe endpoints from flowing through the Xilinx XDMA root port
bridge. This issue affects kernel 6.6.0 and later versions.
This patch allows INTx interrupts generated by PCIe endpoints
to flow through the root port. Tested the fix on a board with
two endpoints generating INTx interrupts. Interrupts are
properly detected and serviced. The /proc/interrupts output
shows:
[...]
32: 320 0 pl_dma:RC-Event 16 Level 400000000.axi-pcie, azdrv
52: 470 0 pl_dma:RC-Event 16 Level 500000000.axi-pcie, azdrv
[...]
Changes since v1::
- Fixed commit message per reviewer's comments
Fixes: 8d786149d78c ("PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver")
Cc: stable@vger.kernel.org
Signed-off-by: Ravi Kumar Bandi <ravib@amazon.com>
---
drivers/pci/controller/pcie-xilinx-dma-pl.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pci/controller/pcie-xilinx-dma-pl.c b/drivers/pci/controller/pcie-xilinx-dma-pl.c
index b037c8f315e4..cc539292d10a 100644
--- a/drivers/pci/controller/pcie-xilinx-dma-pl.c
+++ b/drivers/pci/controller/pcie-xilinx-dma-pl.c
@@ -659,6 +659,12 @@ static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
return err;
}
+ /* Enable interrupts */
+ pcie_write(port, XILINX_PCIE_DMA_IMR_ALL_MASK,
+ XILINX_PCIE_DMA_REG_IMR);
+ pcie_write(port, XILINX_PCIE_DMA_IDRN_MASK,
+ XILINX_PCIE_DMA_REG_IDRN_MASK);
+
return 0;
}
--
2.47.3
next parent reply other threads:[~2025-09-20 22:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C47CF283-C0C4-4ACF-BE07-3E87153D6EC6@amazon.com>
2025-09-20 22:52 ` Ravi Kumar Bandi [this message]
2025-09-24 6:13 ` [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts Bandi, Ravi Kumar
2025-09-29 14:07 ` Manivannan Sadhasivam
2025-10-19 7:10 ` Manivannan Sadhasivam
2025-10-19 7:09 ` Manivannan Sadhasivam
2025-10-27 23:28 ` Bjorn Helgaas
2025-10-28 0:36 ` Bandi, Ravi Kumar
2025-10-21 17:23 ` Bjorn Helgaas
2025-10-21 17:46 ` Bandi, Ravi Kumar
2025-10-21 19:10 ` Bjorn Helgaas
2025-10-21 20:55 ` Bandi, Ravi Kumar
2025-10-21 21:28 ` Bjorn Helgaas
2025-10-21 21:35 ` Bandi, Ravi Kumar
2025-10-22 6:59 ` Stefan Roese
2025-10-22 9:55 ` mani
2025-10-22 9:59 ` Stefan Roese
2025-10-22 10:08 ` Havalige, Thippeswamy
2025-10-22 10:32 ` mani
2025-10-22 10:36 ` Havalige, Thippeswamy
2025-10-22 10:58 ` mani
2025-10-22 12:48 ` Musham, Sai Krishna
2025-10-22 13:10 ` mani
2025-10-23 11:38 ` Musham, Sai Krishna
2025-10-22 13:37 ` Stefan Roese
2025-10-23 6:35 ` Musham, Sai Krishna
2025-10-23 7:03 ` Stefan Roese
2025-10-23 16:11 ` Bjorn Helgaas
2025-10-24 11:59 ` mani
2025-10-22 10:04 ` Havalige, Thippeswamy
2025-10-22 10:06 ` Havalige, Thippeswamy
2025-10-22 10:11 ` Stefan Roese
2025-10-22 10:13 ` Havalige, Thippeswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250920225232.18757-1-ravib@amazon.com \
--to=ravib@amazon.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox