public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <stefan.roese@mailbox.org>
To: "Musham, Sai Krishna" <sai.krishna.musham@amd.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"Havalige, Thippeswamy" <thippeswamy.havalige@amd.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"Bandi, Ravi Kumar" <ravib@amazon.com>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"kwilczynski@kernel.org" <kwilczynski@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"Simek, Michal" <michal.simek@amd.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Sean Anderson <sean.anderson@linux.dev>,
	"Yeleswarapu, Nagaradhesh" <nagaradhesh.yeleswarapu@amd.com>
Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts
Date: Wed, 22 Oct 2025 15:37:30 +0200	[thread overview]
Message-ID: <29bc5e92-04c9-475a-ba3d-a5ea26f1c95a@mailbox.org> (raw)
In-Reply-To: <DM4PR12MB6158ACBA7BCEDB99A55ACA03CDF3A@DM4PR12MB6158.namprd12.prod.outlook.com>

On 10/22/25 14:48, Musham, Sai Krishna wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]

<snip>

>>> We even don’t need ravi patch, as we have tested this at our end it
>>> works fine by just updating interrupt-map Property. We need to now understand the
>> difference in design.
>>
>> Ok, please let us know with your findings. In the meantime, I'll keep Ravi's patch in
>> tree, as it seems to be required on his setup.
>>
> 
> We tested on Linux version 6.12.40 without applying either Stefan's or Ravi's patches.
> Instead, we applied only the following interrupt-map property change (entries 0,1,2,3) and verified that
> legacy interrupts are working correctly.
> 
> interrupt-map = <0 0 0 1 &pcie_intc_0 0>,
> <0 0 0 2 &pcie_intc_0 1>,
> <0 0 0 3 &pcie_intc_0 2>,
> <0 0 0 4 &pcie_intc_0 3>;
> 
> 38:       1143          0  pl_dma:RC-Event  16 Level     80000000.axi-pcie
> 39:       1143          0  pl_dma:INTx   0 Level     nvme0q0, nvme0q1

Okay. Same here. I don't need Ravi's patch for the INTx bit enabling.

I understand that you want us to change the interrupt map in the auto-
generated device-tree from Vivado. Which is IMHO a bit "suboptimal".

I would prefer to have a solution which works out-of-the-box, w/o the
need to manually change DT properties. Is it planned to change / fix
this interrupt map in pl.dtsi generated with a newer version of Vivado?

Thanks,
Stefan


  parent reply	other threads:[~2025-10-22 13:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <C47CF283-C0C4-4ACF-BE07-3E87153D6EC6@amazon.com>
2025-09-20 22:52 ` [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts Ravi Kumar Bandi
2025-09-24  6:13   ` Bandi, Ravi Kumar
2025-09-29 14:07   ` Manivannan Sadhasivam
2025-10-19  7:10     ` Manivannan Sadhasivam
2025-10-19  7:09   ` Manivannan Sadhasivam
2025-10-27 23:28     ` Bjorn Helgaas
2025-10-28  0:36       ` Bandi, Ravi Kumar
2025-10-21 17:23   ` Bjorn Helgaas
2025-10-21 17:46     ` Bandi, Ravi Kumar
2025-10-21 19:10       ` Bjorn Helgaas
2025-10-21 20:55         ` Bandi, Ravi Kumar
2025-10-21 21:28           ` Bjorn Helgaas
2025-10-21 21:35             ` Bandi, Ravi Kumar
2025-10-22  6:59             ` Stefan Roese
2025-10-22  9:55               ` mani
2025-10-22  9:59                 ` Stefan Roese
2025-10-22 10:08                   ` Havalige, Thippeswamy
2025-10-22 10:32                     ` mani
2025-10-22 10:36                       ` Havalige, Thippeswamy
2025-10-22 10:58                         ` mani
2025-10-22 12:48                           ` Musham, Sai Krishna
2025-10-22 13:10                             ` mani
2025-10-23 11:38                               ` Musham, Sai Krishna
2025-10-22 13:37                             ` Stefan Roese [this message]
2025-10-23  6:35                               ` Musham, Sai Krishna
2025-10-23  7:03                                 ` Stefan Roese
2025-10-23 16:11                                   ` Bjorn Helgaas
2025-10-24 11:59                                     ` mani
2025-10-22 10:04                 ` Havalige, Thippeswamy
2025-10-22 10:06                   ` Havalige, Thippeswamy
2025-10-22 10:11                   ` Stefan Roese
2025-10-22 10:13                     ` Havalige, Thippeswamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29bc5e92-04c9-475a-ba3d-a5ea26f1c95a@mailbox.org \
    --to=stefan.roese@mailbox.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=nagaradhesh.yeleswarapu@amd.com \
    --cc=ravib@amazon.com \
    --cc=robh@kernel.org \
    --cc=sai.krishna.musham@amd.com \
    --cc=sean.anderson@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=thippeswamy.havalige@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox